Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_ad_api_msgs): replace adapi message #1897

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Sep 16, 2022

Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp

Description

Replace adapi message and remove the old package.
https://github.com/autowarefoundation/autoware_adapi_msgs

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 10.13% // Head: 10.13% // No change to project coverage 👍

Coverage data is based on head (8e6ff69) compared to base (d61e46a).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1897   +/-   ##
=======================================
  Coverage   10.13%   10.13%           
=======================================
  Files        1256     1256           
  Lines       90741    90741           
  Branches    20517    20517           
=======================================
  Hits         9197     9197           
  Misses      72010    72010           
  Partials     9534     9534           
Flag Coverage Δ *Carryforward flag
differential 9.12% <ø> (?)
total 10.12% <0.00%> (ø) Carriedforward from d61e46a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e_planner/include/obstacle_cruise_planner/node.hpp 0.00% <ø> (ø)
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
...ning/obstacle_cruise_planner/src/polygon_utils.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@isamu-takagi isamu-takagi enabled auto-merge (squash) September 16, 2022 09:32
Copy link
Contributor

@YamatoAndo YamatoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi merged commit 654b905 into autowarefoundation:main Sep 20, 2022
@isamu-takagi isamu-takagi deleted the feature/ad-api/replace-messages branch September 20, 2022 06:37
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…#1897)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…#1897)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…#1897)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…#1897)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants