-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(run_out): add state machine class for state transition #1884
refactor(run_out): add state machine class for state transition #1884
Conversation
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
….universe into refactor-state-transition
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Codecov ReportBase: 10.05% // Head: 9.98% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1884 +/- ##
=========================================
- Coverage 10.05% 9.98% -0.08%
=========================================
Files 1257 1259 +2
Lines 90472 91117 +645
Branches 20335 20788 +453
=========================================
Hits 9094 9094
- Misses 72020 72609 +589
- Partials 9358 9414 +56
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
...cenario_planning/lane_driving/behavior_planning/behavior_velocity_planner/run_out.param.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@TakaHoribe |
(FYI: horibe-san is absent today and I added other owners of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! maybe the config should be reflected to https://github.com/tier4/autoware_launch/pulls also?
yes! I will create the PR for tier4/autoware_launch and post a link in this PR. |
I created PR for tier4/autoware_launch |
…warefoundation#1884) * refactor(run_out): add state machine class for state transition Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * remove debug print Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * move parameters Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add missing parameter Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add documents Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix conflict Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * remove unused argument Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix parameter value Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…warefoundation#1884) * refactor(run_out): add state machine class for state transition Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * remove debug print Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * move parameters Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add missing parameter Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add documents Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix conflict Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * remove unused argument Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix parameter value Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…warefoundation#1884) * refactor(run_out): add state machine class for state transition Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * remove debug print Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * move parameters Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add missing parameter Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add documents Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix conflict Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * remove unused argument Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix parameter value Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…warefoundation#1884) * refactor(run_out): add state machine class for state transition Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * remove debug print Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * move parameters Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add missing parameter Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add documents Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix conflict Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * remove unused argument Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix parameter value Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…warefoundation#1884) * refactor(run_out): add state machine class for state transition Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * remove debug print Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * move parameters Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add missing parameter Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * add documents Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix conflict Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * remove unused argument Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix parameter value Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Description
NOTE: This PR doesn't change the actual behavior because this is just refactoring.
changes for tier4/autoware_launch
tier4/autoware_launch#495
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.