Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(run_out): add state machine class for state transition #1884

Merged

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Sep 15, 2022

Description

  • Refactored state transition
  • Added documents.

NOTE: This PR doesn't change the actual behavior because this is just refactoring.

changes for tier4/autoware_launch
tier4/autoware_launch#495

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo changed the title Refactor state transition refactor(run_out): add state machine class for state transition Sep 15, 2022
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 10.05% // Head: 9.98% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (659e4d6) compared to base (cf5b363).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             main   #1884      +/-   ##
=========================================
- Coverage   10.05%   9.98%   -0.08%     
=========================================
  Files        1257    1259       +2     
  Lines       90472   91117     +645     
  Branches    20335   20788     +453     
=========================================
  Hits         9094    9094              
- Misses      72020   72609     +589     
- Partials     9358    9414      +56     
Flag Coverage Δ *Carryforward flag
differential 4.24% <0.00%> (?)
total 10.03% <0.00%> (ø) Carriedforward from 238bb4c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ner/include/scene_module/run_out/state_machine.hpp 0.00% <0.00%> (ø)
...ity_planner/include/scene_module/run_out/utils.hpp 0.00% <ø> (ø)
...ocity_planner/src/scene_module/run_out/manager.cpp 0.00% <0.00%> (ø)
...elocity_planner/src/scene_module/run_out/scene.cpp 0.00% <0.00%> (ø)
...planner/src/scene_module/run_out/state_machine.cpp 0.00% <0.00%> (ø)
...pic_state_monitor/src/topic_state_monitor_core.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Copy link
Contributor

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo
Copy link
Contributor Author

@TakaHoribe
If there are no problems, could you approve this as code owner of tier4_planning_lancuh package?

@kosuke55
Copy link
Contributor

kosuke55 commented Sep 27, 2022

(FYI: horibe-san is absent today and I added other owners of tier4_planning_lancuh #1955)

@TomohitoAndo
Copy link
Contributor Author

@tkimura4 @shmpwk
If there are no problems, could you approve this as maintainer of the package?

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! maybe the config should be reflected to https://github.com/tier4/autoware_launch/pulls also?

@TomohitoAndo
Copy link
Contributor Author

TomohitoAndo commented Sep 27, 2022

@shmpwk

maybe the config should be reflected to https://github.com/tier4/autoware_launch/pulls also?

yes! I will create the PR for tier4/autoware_launch and post a link in this PR.

@TomohitoAndo
Copy link
Contributor Author

I created PR for tier4/autoware_launch

@TomohitoAndo TomohitoAndo merged commit e3292d2 into autowarefoundation:main Sep 27, 2022
@TomohitoAndo TomohitoAndo deleted the refactor-state-transition branch September 27, 2022 09:07
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…warefoundation#1884)

* refactor(run_out): add state machine class for state transition

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* remove debug print

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* move parameters

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add missing parameter

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add documents

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix conflict

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* remove unused argument

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix parameter value

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Sep 29, 2022
…warefoundation#1884)

* refactor(run_out): add state machine class for state transition

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* remove debug print

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* move parameters

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add missing parameter

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add documents

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix conflict

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* remove unused argument

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix parameter value

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…warefoundation#1884)

* refactor(run_out): add state machine class for state transition

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* remove debug print

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* move parameters

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add missing parameter

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add documents

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix conflict

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* remove unused argument

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix parameter value

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…warefoundation#1884)

* refactor(run_out): add state machine class for state transition

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* remove debug print

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* move parameters

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add missing parameter

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add documents

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix conflict

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* remove unused argument

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix parameter value

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…warefoundation#1884)

* refactor(run_out): add state machine class for state transition

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* remove debug print

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* move parameters

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add missing parameter

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* add documents

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix conflict

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* remove unused argument

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix parameter value

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants