Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): refactor pull_over #1842

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 12, 2022

Description

refactor pull_over

  • remove unnecessary functions and variables, args.
  • refactor each function

Related links

Tests performed

psim

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1842 (3f35ba0) into main (cb2552b) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1842      +/-   ##
==========================================
- Coverage   10.44%   10.32%   -0.13%     
==========================================
  Files        1221     1221              
  Lines       87728    89055    +1327     
  Branches    20493    21431     +938     
==========================================
+ Hits         9160     9191      +31     
- Misses      69091    70299    +1208     
- Partials     9477     9565      +88     
Flag Coverage Δ *Carryforward flag
differential 2.49% <0.00%> (?)
total 10.42% <0.00%> (ø) Carriedforward from cb2552b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/pull_over/pull_over_module.hpp 0.00% <ø> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 23.52% <ø> (-1.48%) ⬇️
...or_path_planner/src/behavior_path_planner_node.cpp 0.43% <0.00%> (+0.21%) ⬆️
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
...r_path_planner/src/scene_module/pull_over/util.cpp 0.00% <0.00%> (ø)
planning/route_handler/src/route_handler.cpp 0.00% <0.00%> (ø)
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L

@kosuke55 kosuke55 merged commit f218b96 into autowarefoundation:main Sep 12, 2022
@kosuke55 kosuke55 deleted the refactor/pull_over branch September 12, 2022 13:08
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…on#1842)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…on#1842)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…on#1842)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
…on#1842)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 18, 2022
…on#1842)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…on#1842)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 10, 2022
…on#1842)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2022
…on#1842)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants