Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): add explanations for holding the closest stop obstacle #1835

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Sep 12, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Update readme to add the explanations about how to keep the closest stop obstacle in the target obstacles.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…st stop obstacle

Signed-off-by: yutaka <purewater0901@gmail.com>
@takayuki5168 takayuki5168 added the type:documentation Creating or refining documentation. (auto-assigned) label Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1835 (1336d55) into main (cb2552b) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1835   +/-   ##
=======================================
  Coverage   10.44%   10.44%           
=======================================
  Files        1221     1221           
  Lines       87728    87728           
  Branches    20493    20493           
=======================================
  Hits         9160     9160           
  Misses      69091    69091           
  Partials     9477     9477           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.42% <0.00%> (ø) Carriedforward from cb2552b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/behavior_velocity_planner/planner_data.hpp 0.00% <0.00%> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.42% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit 25c30f2 into autowarefoundation:main Sep 12, 2022
@purewater0901 purewater0901 deleted the feat/add-holding-document branch September 12, 2022 10:24
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…st stop obstacle (autowarefoundation#1835)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…st stop obstacle (autowarefoundation#1835)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…st stop obstacle (autowarefoundation#1835)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…st stop obstacle (autowarefoundation#1835)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants