Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): decrease pull_over hz #1819

Merged
merged 3 commits into from
Sep 9, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 8, 2022

Description

Decrease pull_over hz.

  • generate drivable area only for selected path.
  • pull_over also be updated

Related links

Tests performed

psim

check that output path is 10 hz in worst case.

Screenshot from 2022-09-09 01-11-22

and check that pull_out does not degrade.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 enabled auto-merge (squash) September 8, 2022 17:22
@kosuke55 kosuke55 force-pushed the feat/pull_over_decrease_hz branch from 9b19d06 to 9d97416 Compare September 8, 2022 17:37
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/pull_over_decrease_hz branch from 9d97416 to d0981be Compare September 8, 2022 17:39
@kosuke55 kosuke55 changed the title feat(behavior_path_planner): pull_over decrease hz feat(behavior_path_planner): decrease pull_over hz Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1819 (802cedb) into main (c0f3507) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1819      +/-   ##
==========================================
- Coverage   10.40%   10.33%   -0.08%     
==========================================
  Files        1218     1218              
  Lines       87550    88155     +605     
  Branches    20511    20954     +443     
==========================================
  Hits         9109     9109              
- Misses      68981    69558     +577     
- Partials     9460     9488      +28     
Flag Coverage Δ *Carryforward flag
differential 1.29% <0.00%> (?)
total 10.38% <0.00%> (ø) Carriedforward from d0981be

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
...r_path_planner/src/scene_module/pull_over/util.cpp 0.00% <0.00%> (ø)
.../scene_module/utils/geometric_parallel_parking.cpp 0.00% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 merged commit c320ed4 into autowarefoundation:main Sep 9, 2022
@kosuke55 kosuke55 deleted the feat/pull_over_decrease_hz branch September 9, 2022 02:17
voltonomous pushed a commit to vautonomous/autoware.universe that referenced this pull request Sep 11, 2022
…n#1819)

* feat(behavior_path_planner): pull_over decrease hz

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* generate drivable area at last in pull_out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…n#1819)

* feat(behavior_path_planner): pull_over decrease hz

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* generate drivable area at last in pull_out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…n#1819)

* feat(behavior_path_planner): pull_over decrease hz

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* generate drivable area at last in pull_out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…n#1819)

* feat(behavior_path_planner): pull_over decrease hz

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* generate drivable area at last in pull_out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2022
…n#1819)

* feat(behavior_path_planner): pull_over decrease hz

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* generate drivable area at last in pull_out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 14, 2022
…n#1819)

* feat(behavior_path_planner): pull_over decrease hz

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* generate drivable area at last in pull_out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2022
…n#1819)

* feat(behavior_path_planner): pull_over decrease hz

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* generate drivable area at last in pull_out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 18, 2022
…n#1819)

* feat(behavior_path_planner): pull_over decrease hz

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* generate drivable area at last in pull_out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…n#1819)

* feat(behavior_path_planner): pull_over decrease hz

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* generate drivable area at last in pull_out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 10, 2022
…n#1819)

* feat(behavior_path_planner): pull_over decrease hz

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* generate drivable area at last in pull_out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 30, 2022
…n#1819)

* feat(behavior_path_planner): pull_over decrease hz

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* generate drivable area at last in pull_out

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants