-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): decrease pull_over hz #1819
feat(behavior_path_planner): decrease pull_over hz #1819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9b19d06
to
9d97416
Compare
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
9d97416
to
d0981be
Compare
Codecov Report
@@ Coverage Diff @@
## main #1819 +/- ##
==========================================
- Coverage 10.40% 10.33% -0.08%
==========================================
Files 1218 1218
Lines 87550 88155 +605
Branches 20511 20954 +443
==========================================
Hits 9109 9109
- Misses 68981 69558 +577
- Partials 9460 9488 +28
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#1819) * feat(behavior_path_planner): pull_over decrease hz Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * generate drivable area at last in pull_out Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#1819) * feat(behavior_path_planner): pull_over decrease hz Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * generate drivable area at last in pull_out Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#1819) * feat(behavior_path_planner): pull_over decrease hz Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * generate drivable area at last in pull_out Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#1819) * feat(behavior_path_planner): pull_over decrease hz Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * generate drivable area at last in pull_out Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#1819) * feat(behavior_path_planner): pull_over decrease hz Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * generate drivable area at last in pull_out Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#1819) * feat(behavior_path_planner): pull_over decrease hz Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * generate drivable area at last in pull_out Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#1819) * feat(behavior_path_planner): pull_over decrease hz Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * generate drivable area at last in pull_out Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#1819) * feat(behavior_path_planner): pull_over decrease hz Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * generate drivable area at last in pull_out Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#1819) * feat(behavior_path_planner): pull_over decrease hz Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * generate drivable area at last in pull_out Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#1819) * feat(behavior_path_planner): pull_over decrease hz Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * generate drivable area at last in pull_out Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…n#1819) * feat(behavior_path_planner): pull_over decrease hz Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * generate drivable area at last in pull_out Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Description
Decrease pull_over hz.
Related links
Tests performed
psim
check that output path is 10 hz in worst case.
and check that pull_out does not degrade.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.