-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ekf_localizer): rename biased pose topics #1787
Merged
Merged
+23
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1787 +/- ##
==========================================
- Coverage 10.40% 10.39% -0.02%
==========================================
Files 1222 1222
Lines 87510 87646 +136
Branches 20490 20601 +111
==========================================
Hits 9109 9109
- Misses 68925 69048 +123
- Partials 9476 9489 +13
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kminoda
added
the
component:localization
Vehicle's position determination in its environment. (auto-assigned)
label
Sep 6, 2022
kminoda
reviewed
Sep 6, 2022
localization/ekf_localizer/include/ekf_localizer/ekf_localizer.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
@IshitaTakeshi Thanks for the refactoring. |
8 tasks
YamatoAndo
approved these changes
Sep 6, 2022
3 tasks
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Sep 28, 2022
* fix(ekf_localizer): rename biased pose topics * Update topic descriptions in README Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
* fix(ekf_localizer): rename biased pose topics * Update topic descriptions in README Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
* fix(ekf_localizer): rename biased pose topics * Update topic descriptions in README Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 19, 2022
* fix(ekf_localizer): rename biased pose topics * Update topic descriptions in README Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current topic names such as
pose_without_yawbias
imply publishing poses without yaw bias, but actually, it has the bias. So I renamed these topics to explicitly indicate that they have the bias.Related links
On the current code, there's no bias correction when creating the corresponding message.
autoware.universe/localization/ekf_localizer/src/ekf_localizer.cpp
Line 233 in 57c4b1f
Tests performed
There are no tests performed for this PR but I checked the behavior on the logging simulator.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.