Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ekf_localizer): rename biased pose topics #1787

Merged
merged 6 commits into from
Sep 6, 2022

Conversation

IshitaTakeshi
Copy link
Contributor

@IshitaTakeshi IshitaTakeshi commented Sep 5, 2022

Description

The current topic names such as pose_without_yawbias imply publishing poses without yaw bias, but actually, it has the bias. So I renamed these topics to explicitly indicate that they have the bias.

Related links

On the current code, there's no bias correction when creating the corresponding message.

current_ekf_pose_no_yawbias_.pose.orientation =

Tests performed

There are no tests performed for this PR but I checked the behavior on the logging simulator.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1787 (b10afec) into main (73bd233) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1787      +/-   ##
==========================================
- Coverage   10.40%   10.39%   -0.02%     
==========================================
  Files        1222     1222              
  Lines       87510    87646     +136     
  Branches    20490    20601     +111     
==========================================
  Hits         9109     9109              
- Misses      68925    69048     +123     
- Partials     9476     9489      +13     
Flag Coverage Δ *Carryforward flag
differential 11.82% <0.00%> (?)
total 10.39% <0.00%> (ø) Carriedforward from fd792c0

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._localizer/include/ekf_localizer/ekf_localizer.hpp 0.00% <ø> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kminoda kminoda added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Sep 6, 2022
IshitaTakeshi and others added 3 commits September 6, 2022 13:52
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
@IshitaTakeshi IshitaTakeshi merged commit 8c198af into main Sep 6, 2022
@IshitaTakeshi IshitaTakeshi deleted the fix/rename-biased-yaw branch September 6, 2022 09:43
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
* fix(ekf_localizer): rename biased pose topics
* Update topic descriptions in README

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
* fix(ekf_localizer): rename biased pose topics
* Update topic descriptions in README

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
* fix(ekf_localizer): rename biased pose topics
* Update topic descriptions in README

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
* fix(ekf_localizer): rename biased pose topics
* Update topic descriptions in README

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants