Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(run_out): use util function to calculate stop point #1780

Merged

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Sep 5, 2022

Description

Modified to use functions in motion_utils to calculate stop point.
I confirmed this works with planning simulator.

use-util-run-out-psim.mp4

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo changed the title Use util function refactor(run_out): use util function to calculate stop point Sep 5, 2022
@TomohitoAndo TomohitoAndo requested review from 0x126 and mkuri September 5, 2022 07:14
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1780 (de4d662) into main (2f379a6) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1780      +/-   ##
==========================================
- Coverage   10.35%   10.33%   -0.03%     
==========================================
  Files        1218     1218              
  Lines       87375    87551     +176     
  Branches    20224    20320      +96     
==========================================
  Hits         9051     9051              
- Misses      68874    69047     +173     
- Partials     9450     9453       +3     
Flag Coverage Δ *Carryforward flag
differential 4.21% <0.00%> (?)
total 10.34% <0.00%> (ø) Carriedforward from 397f367

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/include/scene_module/run_out/path_utils.hpp 0.00% <ø> (ø)
...elocity_planner/src/scene_module/run_out/scene.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Copy link
Contributor

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo merged commit 15b28b9 into autowarefoundation:main Sep 6, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…efoundation#1780)

* refactor: use util function to calculate stop point

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unnecessary debug marker

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: revert an unrelated change

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…efoundation#1780)

* refactor: use util function to calculate stop point

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unnecessary debug marker

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: revert an unrelated change

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…efoundation#1780)

* refactor: use util function to calculate stop point

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unnecessary debug marker

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: revert an unrelated change

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…efoundation#1780)

* refactor: use util function to calculate stop point

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unnecessary debug marker

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: revert an unrelated change

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo deleted the use-util-function branch November 24, 2022 06:29
TomohitoAndo added a commit to TomohitoAndo/autoware.universe that referenced this pull request Nov 25, 2022
…efoundation#1780)

* refactor: use util function to calculate stop point

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: remove unnecessary debug marker

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* refactor: revert an unrelated change

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants