-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(run_out): use util function to calculate stop point #1780
refactor(run_out): use util function to calculate stop point #1780
Conversation
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Codecov Report
@@ Coverage Diff @@
## main #1780 +/- ##
==========================================
- Coverage 10.35% 10.33% -0.03%
==========================================
Files 1218 1218
Lines 87375 87551 +176
Branches 20224 20320 +96
==========================================
Hits 9051 9051
- Misses 68874 69047 +173
- Partials 9450 9453 +3
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…efoundation#1780) * refactor: use util function to calculate stop point Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unnecessary debug marker Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: revert an unrelated change Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…efoundation#1780) * refactor: use util function to calculate stop point Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unnecessary debug marker Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: revert an unrelated change Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…efoundation#1780) * refactor: use util function to calculate stop point Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unnecessary debug marker Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: revert an unrelated change Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…efoundation#1780) * refactor: use util function to calculate stop point Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unnecessary debug marker Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: revert an unrelated change Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…efoundation#1780) * refactor: use util function to calculate stop point Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: remove unnecessary debug marker Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * refactor: revert an unrelated change Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Description
Modified to use functions in motion_utils to calculate stop point.
I confirmed this works with planning simulator.
use-util-run-out-psim.mp4
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.