Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mission_planner): fix function name renaming #1760

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Sep 1, 2022

Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp

Description

Fix #1737

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@kosuke55 kosuke55 self-requested a review September 1, 2022 07:29
@kosuke55
Copy link
Contributor

kosuke55 commented Sep 1, 2022

before
mission planner dies

[component_container-43] /opt/ros/galactic/lib/rclcpp_components/component_container: symbol lookup error: /home/kosuke55/pilot-auto/install/mission_planner/lib/libmission_planner_component.so: undefined symbol: _Z9set_colorPN8std_msgs3msg10ColorRGBA_ISaIvEEEdddd
[ERROR] [component_container-43]: process has died [pid 3330998, exit code 127, cmd '/opt/ros/galactic/lib/rclcpp_components/component_container --ros-args -r __node:=mission_planning_container -r __ns:=/planning/mission_planning --params-file /tmp/launch_params_2ef6pz65'].

after
mission planner does not die

image

@isamu-takagi isamu-takagi self-assigned this Sep 1, 2022
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi enabled auto-merge (squash) September 1, 2022 07:33
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1760 (8744be0) into main (df0fd74) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1760   +/-   ##
=======================================
  Coverage   10.32%   10.32%           
=======================================
  Files        1207     1207           
  Lines       86961    86961           
  Branches    20076    20076           
=======================================
  Hits         8981     8981           
  Misses      68677    68677           
  Partials     9303     9303           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.31% <0.00%> (ø) Carriedforward from df0fd74

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...src/mission_planner_lanelet2/utility_functions.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@isamu-takagi isamu-takagi merged commit da61e26 into autowarefoundation:main Sep 1, 2022
@isamu-takagi isamu-takagi deleted the fix/function-name-mission-planner branch September 1, 2022 09:18
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…1760)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…1760)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…1760)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…1760)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…1760)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants