Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_utils): add interpolation function #1738

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Aug 31, 2022

Description

Currently, autoware has multiple same implementations of the calcInterpolatedTrajectoryPoint function, and I add it to the utils function with unit tests

Related links

Tests performed

Unit Tests

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1738 (a572a2b) into main (5808c3f) will increase coverage by 0.04%.
The diff coverage is 30.76%.

@@            Coverage Diff             @@
##             main    #1738      +/-   ##
==========================================
+ Coverage   10.28%   10.32%   +0.04%     
==========================================
  Files        1204     1206       +2     
  Lines       86817    87108     +291     
  Branches    20054    20207     +153     
==========================================
+ Hits         8930     8998      +68     
- Misses      68591    68674      +83     
- Partials     9296     9436     +140     
Flag Coverage Δ *Carryforward flag
differential 11.01% <30.76%> (?)
total 10.27% <ø> (ø) Carriedforward from 5808c3f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...n_utils/test/src/trajectory/test_interpolation.cpp 18.75% <18.75%> (ø)
...mmon/motion_utils/src/trajectory/interpolation.cpp 96.87% <96.87%> (ø)
...ning_rviz_plugin/src/path_with_lane_id/display.cpp 0.00% <0.00%> (ø)
...ils/include/motion_utils/trajectory/trajectory.hpp 79.50% <0.00%> (+0.75%) ⬆️
...planning_evaluator/src/planning_evaluator_node.cpp 38.14% <0.00%> (+1.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit c07c13b into autowarefoundation:main Sep 1, 2022
@purewater0901 purewater0901 deleted the feat/add-calcInterpolatedPpoint-function branch September 1, 2022 05:56
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* feat(tier4_autoware_utils): add point to tfvector function

Signed-off-by: yutaka <purewater0901@gmail.com>

* add interpolation function

Signed-off-by: yutaka <purewater0901@gmail.com>

* add tests

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(tier4_autoware_utils): add point to tfvector function

Signed-off-by: yutaka <purewater0901@gmail.com>

* add interpolation function

Signed-off-by: yutaka <purewater0901@gmail.com>

* add tests

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(tier4_autoware_utils): add point to tfvector function

Signed-off-by: yutaka <purewater0901@gmail.com>

* add interpolation function

Signed-off-by: yutaka <purewater0901@gmail.com>

* add tests

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
* feat(tier4_autoware_utils): add point to tfvector function

Signed-off-by: yutaka <purewater0901@gmail.com>

* add interpolation function

Signed-off-by: yutaka <purewater0901@gmail.com>

* add tests

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* feat(tier4_autoware_utils): add point to tfvector function

Signed-off-by: yutaka <purewater0901@gmail.com>

* add interpolation function

Signed-off-by: yutaka <purewater0901@gmail.com>

* add tests

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants