Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): geometric parallel parking debug pose #1731

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 30, 2022

Description

fix mistake of debug pose caused in
#1534

Related links

#1534

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 requested a review from takayuki5168 August 30, 2022 07:19
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1731 (595cbaa) into main (1d10ff3) will decrease coverage by 0.09%.
The diff coverage is 9.30%.

@@            Coverage Diff             @@
##             main    #1731      +/-   ##
==========================================
- Coverage   10.25%   10.16%   -0.10%     
==========================================
  Files        1204     1205       +1     
  Lines       86787    87954    +1167     
  Branches    20063    20890     +827     
==========================================
+ Hits         8904     8937      +33     
- Misses      68613    69672    +1059     
- Partials     9270     9345      +75     
Flag Coverage Δ *Carryforward flag
differential 1.26% <10.08%> (?)
total 10.24% <7.93%> (ø) Carriedforward from 1d10ff3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ils/test/src/trajectory/test_path_with_lane_id.cpp 43.28% <0.00%> (ø)
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <0.00%> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)
...r_path_planner/scene_module/utils/path_shifter.hpp 0.00% <ø> (ø)
...lude/behavior_path_planner/turn_signal_decider.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.17% <0.00%> (-0.06%) ⬇️
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
... and 75 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kosuke55 kosuke55 enabled auto-merge (squash) August 30, 2022 09:55
@kosuke55 kosuke55 merged commit 7a94f46 into autowarefoundation:main Aug 30, 2022
@kosuke55 kosuke55 deleted the fix/pull_over_debug_pose branch August 30, 2022 10:02
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…er4#1731)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…er4#1731)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…er4#1731)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 13, 2022
)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 14, 2022
)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…towarefoundation#1731)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 18, 2022
)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…er4#1731)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Nov 10, 2022
)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Nov 30, 2022
)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants