Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): fix stop condition #1730

Merged

Conversation

purewater0901
Copy link
Contributor

Signed-off-by: yutaka purewater0901@gmail.com

Description

Change stop condition to avoid causing problems for the entire code.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 enabled auto-merge (squash) August 30, 2022 07:29
@purewater0901 purewater0901 merged commit 7224909 into autowarefoundation:main Aug 30, 2022
@purewater0901 purewater0901 deleted the fix/cruise-stop-condition branch August 30, 2022 09:46
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1730 (34d8a6e) into main (fbcfee1) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1730   +/-   ##
=======================================
  Coverage   10.24%   10.24%           
=======================================
  Files        1204     1204           
  Lines       86772    86772           
  Branches    20054    20054           
=======================================
  Hits         8894     8894           
  Misses      68616    68616           
  Partials     9262     9262           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.23% <0.00%> (ø) Carriedforward from fbcfee1

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../obstacle_cruise_planner/src/planner_interface.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants