-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vehicle_velocity_converter): simpify parameter inputs #1727
Merged
kminoda
merged 3 commits into
autowarefoundation:main
from
kminoda:fix/simplify_vehicle_velocity_converter_parameter_input
Aug 30, 2022
Merged
fix(vehicle_velocity_converter): simpify parameter inputs #1727
kminoda
merged 3 commits into
autowarefoundation:main
from
kminoda:fix/simplify_vehicle_velocity_converter_parameter_input
Aug 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
kminoda
added
the
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
label
Aug 30, 2022
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1727 +/- ##
==========================================
- Coverage 10.25% 10.25% -0.01%
==========================================
Files 1204 1204
Lines 86697 86706 +9
Branches 20020 20020
==========================================
Hits 8894 8894
- Misses 68541 68550 +9
Partials 9262 9262
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I think the 6x6 matrix would be fine as its input, but I would like to respect your opinion. |
YamatoAndo
approved these changes
Aug 30, 2022
1222-takeshi
referenced
this pull request
in tier4/autoware.universe
Sep 12, 2022
* fix(vehicle_velocity_converter): simpify parameter inputs Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix readme and default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> Signed-off-by: kminoda <koji.m.minoda@gmail.com>
1222-takeshi
referenced
this pull request
in tier4/autoware.universe
Sep 12, 2022
* fix(vehicle_velocity_converter): simpify parameter inputs Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix readme and default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> Signed-off-by: kminoda <koji.m.minoda@gmail.com> Signed-off-by: kminoda <koji.m.minoda@gmail.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
kminoda
deleted the
fix/simplify_vehicle_velocity_converter_parameter_input
branch
September 15, 2022 07:56
tkimura4
referenced
this pull request
in tier4/autoware.universe
Sep 20, 2022
* fix(vehicle_velocity_converter): simpify parameter inputs Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix readme and default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> Signed-off-by: kminoda <koji.m.minoda@gmail.com> Signed-off-by: kminoda <koji.m.minoda@gmail.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Sep 28, 2022
* fix(vehicle_velocity_converter): simpify parameter inputs Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix readme and default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> Signed-off-by: kminoda <koji.m.minoda@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
* fix(vehicle_velocity_converter): simpify parameter inputs Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix readme and default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> Signed-off-by: kminoda <koji.m.minoda@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
* fix(vehicle_velocity_converter): simpify parameter inputs Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix readme and default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> Signed-off-by: kminoda <koji.m.minoda@gmail.com>
yukke42
pushed a commit
to tzhong518/autoware.universe
that referenced
this pull request
Oct 14, 2022
…undation#1727) * fix(vehicle_velocity_converter): simpify parameter inputs Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix readme and default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> Signed-off-by: kminoda <koji.m.minoda@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 19, 2022
* fix(vehicle_velocity_converter): simpify parameter inputs Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix readme and default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> Signed-off-by: kminoda <koji.m.minoda@gmail.com>
badai-nguyen
pushed a commit
to badai-nguyen/autoware.universe
that referenced
this pull request
Feb 2, 2023
…undation#1727) (autowarefoundation#118) * fix(vehicle_velocity_converter): simpify parameter inputs Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix readme and default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> * fix default value Signed-off-by: kminoda <koji.m.minoda@gmail.com> Signed-off-by: kminoda <koji.m.minoda@gmail.com> Signed-off-by: kminoda <koji.m.minoda@gmail.com> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kminoda koji.m.minoda@gmail.com
Description
I propose to simplify the parameter input of
vehicle_velocity_converter
. Since the 6x6 matrix input is too redundant, the node should be provided with only two essential values, the standard deviation of vx and wz.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.