Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner): export scene module libraries for faster build #1722

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Aug 29, 2022

export each scene module library and then link the main node for faster build

Signed-off-by: Mamoru Sobue mamoru.sobue@tier4.jp

Description

In this PR each scene_module is compiled to libbehavior_velocity_planner_${scene_module}.so and then the main planner node is linked against them.

If one of the scene module source file, say scene_module/intersection/scene_intersection.cpp, is changed, then only libbehavior_velocity_planner_intersection.so is built and linked again.

Tests performed

(TODO excluding test/ dir)

Measured

time colcon build --packages-up-to behavior_velocity_planner

.

build type before PR this PR
clean build xxx sec 192s
after one src file edit xxx sec 38s

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…r faster build

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin closed this Aug 29, 2022
@soblin soblin deleted the refactor/behavior-vel-divide-module-library branch November 23, 2022 13:34
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Dec 26, 2024
…age at crosswalks (autowarefoundation#1722)

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant