Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner): fix safety slow down crosswalk intersection check #1708

Conversation

mehmetdogru
Copy link
Contributor

@mehmetdogru mehmetdogru commented Aug 26, 2022

Signed-off-by: Mehmet Dogru 42mehmetdogru42@gmail.com

Related PR: #1528

Description

Small bug / when there is no intersection between safety slow down crosswalk and the path bvp crashes.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ection check

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
@mehmetdogru mehmetdogru added type:bug Software flaws or errors. component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Aug 26, 2022
@mehmetdogru mehmetdogru self-assigned this Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #1708 (f7fc3a9) into main (d9fae78) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1708      +/-   ##
==========================================
- Coverage   10.25%   10.23%   -0.03%     
==========================================
  Files        1199     1199              
  Lines       86374    86575     +201     
  Branches    19891    20035     +144     
==========================================
  Hits         8860     8860              
- Misses      68294    68489     +195     
- Partials     9220     9226       +6     
Flag Coverage Δ *Carryforward flag
differential 4.13% <0.00%> (?)
total 10.24% <0.00%> (ø) Carriedforward from d9fae78

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ner/src/scene_module/crosswalk/scene_crosswalk.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@beyzanurkaya beyzanurkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before these changes, the module was working as in the video below. Although crosswalk_module was registered, the package was crashing because there was no intersection between path and crosswalk.

test-before-changes.mp4

But after this changes it works as in this video:

test-after-changes.mp4

Problem is solved with these changes.

@beyzanurkaya beyzanurkaya merged commit 7f3389e into autowarefoundation:main Aug 26, 2022
@mehmetdogru mehmetdogru deleted the fix/behavior_velocity_planner-safety-slow-down-crosswalk-intersection-check branch August 26, 2022 14:22
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…ection check (tier4#1708)

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ection check (tier4#1708)

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ection check (tier4#1708)

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ection check (autowarefoundation#1708)

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…ection check (tier4#1708)

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
saka1-s added a commit to saka1-s/autoware.universe that referenced this pull request Dec 22, 2024
…561/v0.29.0-1

fix(intersection): cherry pick/pr8561 v0.29.0-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:bug Software flaws or errors.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants