-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_velocity_planner): fix safety slow down crosswalk intersection check #1708
Conversation
…ection check Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1708 +/- ##
==========================================
- Coverage 10.25% 10.23% -0.03%
==========================================
Files 1199 1199
Lines 86374 86575 +201
Branches 19891 20035 +144
==========================================
Hits 8860 8860
- Misses 68294 68489 +195
- Partials 9220 9226 +6
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before these changes, the module was working as in the video below. Although crosswalk_module was registered, the package was crashing because there was no intersection between path and crosswalk.
test-before-changes.mp4
But after this changes it works as in this video:
test-after-changes.mp4
Problem is solved with these changes.
…ection check (tier4#1708) Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
…ection check (tier4#1708) Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
…ection check (tier4#1708) Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
…ection check (autowarefoundation#1708) Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
…ection check (tier4#1708) Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com> Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
…561/v0.29.0-1 fix(intersection): cherry pick/pr8561 v0.29.0-1
Signed-off-by: Mehmet Dogru 42mehmetdogru42@gmail.com
Related PR: #1528
Description
Small bug / when there is no intersection between safety slow down crosswalk and the path bvp crashes.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.