Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_velocity_smoother): fix stop point #1694

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Aug 25, 2022

Description

  • fix motion velocity smoother stop index
    Note this will read to segmentation fault at edge case
std::vector<autoware_auto_planning_msgs::msg::TrajectoryPoint_<std::allocator<void> >, std::allocator<autoware_auto_planning_msgs::msg::TrajectoryPoint_<std::allocator<void> > > >::_M_range_check(unsigned long) const 

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1694 (123a555) into main (8f7f923) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1694   +/-   ##
=======================================
  Coverage   10.72%   10.72%           
=======================================
  Files        1103     1103           
  Lines       78394    78394           
  Branches    18649    18649           
=======================================
  Hits         8409     8409           
  Misses      61071    61071           
  Partials     8914     8914           
Flag Coverage Δ *Carryforward flag
differential 3.50% <0.00%> (?)
total 10.71% <0.00%> (ø) Carriedforward from 8f7f923

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ity_smoother/src/motion_velocity_smoother_node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@taikitanaka3 taikitanaka3 merged commit 5e2cd46 into autowarefoundation:main Aug 26, 2022
@taikitanaka3 taikitanaka3 deleted the fix/motion_velocity_smoother_stop_point_segfo branch August 26, 2022 00:28
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
h-ohta referenced this pull request in tier4/autoware.universe Jun 9, 2023
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
h-ohta referenced this pull request in tier4/autoware.universe Jun 23, 2023
fix(motion_velocity_smoother): fix stop point (#1694)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants