Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): add closest stop point to resampled points #1691

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Aug 25, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Add closest stop point to the resampled point.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…points

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 changed the title feat(behavior_velocity_planner): add closest stop point to resampled points feat(behavior_path_planner): add closest stop point to resampled points Aug 25, 2022
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thaks, looks good

@kosuke55
Copy link
Contributor

kosuke55 commented Aug 25, 2022

related to #1604.
It added resampling to the end of behavior_path. It removes the original stop point which is set in scene_module.
This PR can keep the original stop point.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1691 (e49cd54) into main (8f7f923) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1691      +/-   ##
==========================================
- Coverage   10.72%   10.65%   -0.07%     
==========================================
  Files        1103     1103              
  Lines       78394    78889     +495     
  Branches    18649    18994     +345     
==========================================
  Hits         8409     8409              
- Misses      61071    61524     +453     
- Partials     8914     8956      +42     
Flag Coverage Δ *Carryforward flag
differential 0.79% <0.00%> (?)
total 10.71% <0.00%> (ø) Carriedforward from 5ec4487

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 0.85% <0.00%> (-0.20%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@purewater0901 purewater0901 merged commit 96123b5 into autowarefoundation:main Aug 25, 2022
@purewater0901 purewater0901 deleted the feat/add-stop-point-to-resampling branch August 25, 2022 11:41
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…ts (tier4#1691)

* feat(behavior_velocity_planner): add closest stop point to resampled points

Signed-off-by: yutaka <purewater0901@gmail.com>

* first commit

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ts (tier4#1691)

* feat(behavior_velocity_planner): add closest stop point to resampled points

Signed-off-by: yutaka <purewater0901@gmail.com>

* first commit

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ts (tier4#1691)

* feat(behavior_velocity_planner): add closest stop point to resampled points

Signed-off-by: yutaka <purewater0901@gmail.com>

* first commit

Signed-off-by: yutaka <purewater0901@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ts (autowarefoundation#1691)

* feat(behavior_velocity_planner): add closest stop point to resampled points

Signed-off-by: yutaka <purewater0901@gmail.com>

* first commit

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…ts (tier4#1691)

* feat(behavior_velocity_planner): add closest stop point to resampled points

Signed-off-by: yutaka <purewater0901@gmail.com>

* first commit

Signed-off-by: yutaka <purewater0901@gmail.com>
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Dec 26, 2024
…_camera_num_limit

feat: remove max rois limit in the image projection based fusion (autowarefoundation#9596)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants