Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planenr): add header on debug path msgs #1679

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Aug 24, 2022

Description

Without header, we can't visualize the debug paths on Rviz.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@taikitanaka3
Copy link
Contributor

@TakaHoribe
Thank you for PR can you also set this param to false by default? I commited without reverting this debug testing

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #1679 (e802b9f) into main (7b94ead) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1679      +/-   ##
==========================================
- Coverage   10.72%   10.71%   -0.01%     
==========================================
  Files        1103     1103              
  Lines       78410    78452      +42     
  Branches    18649    18663      +14     
==========================================
  Hits         8409     8409              
- Misses      61087    61123      +36     
- Partials     8914     8920       +6     
Flag Coverage Δ *Carryforward flag
differential 4.13% <ø> (?)
total 10.70% <0.00%> (ø) Carriedforward from 7b94ead

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/include/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TakaHoribe
Copy link
Contributor Author

@taikitanaka3 I'll make another PR.

@TakaHoribe
Copy link
Contributor Author

@taikitanaka3 FYI. #1680

@taikitanaka3 taikitanaka3 merged commit fcf1302 into autowarefoundation:main Aug 25, 2022
@taikitanaka3 taikitanaka3 deleted the fix/add-header-for-debug-msg branch August 25, 2022 00:35
@taikitanaka3
Copy link
Contributor

@TakaHoribe
I added these two PRs to release note

boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…1679)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…1679)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…1679)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…refoundation#1679)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…1679)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants