Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_utils): add guard #1666

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Aug 23, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Currently, resampling functions in motion utils do not have guards to prevent them from inserting the same points in input arclength. In this PR, I add a guard to enable the resampling function to avoid having same points.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
purewater0901 and others added 3 commits August 25, 2022 13:34
Signed-off-by: yutaka <purewater0901@gmail.com>
…ier4/autoware.universe into feat/add-guard-to-resampling-functions
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@taikitanaka3
Copy link
Contributor

@purewater0901
can you fix unit test?

Signed-off-by: yutaka <purewater0901@gmail.com>
@taikitanaka3 taikitanaka3 enabled auto-merge (squash) August 25, 2022 09:32
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1666 (9da02b6) into main (a8a58c0) will increase coverage by 0.44%.
The diff coverage is 32.35%.

@@            Coverage Diff             @@
##             main    #1666      +/-   ##
==========================================
+ Coverage   10.73%   11.17%   +0.44%     
==========================================
  Files        1103     1103              
  Lines       78356    79418    +1062     
  Branches    18649    19577     +928     
==========================================
+ Hits         8409     8877     +468     
- Misses      61033    61317     +284     
- Partials     8914     9224     +310     
Flag Coverage Δ *Carryforward flag
differential 10.77% <9.15%> (?)
total 10.70% <29.49%> (-0.01%) ⬇️ Carriedforward from 920ae85

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...n/motion_utils/test/src/resample/test_resample.cpp 34.74% <31.25%> (+8.73%) ⬆️
common/motion_utils/src/resample/resample.cpp 50.54% <33.33%> (+5.28%) ⬆️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 73.58% <0.00%> (-9.44%) ⬇️
planning/surround_obstacle_checker/src/node.cpp 0.00% <0.00%> (ø)
...ing/surround_obstacle_checker/src/debug_marker.cpp 0.00% <0.00%> (ø)
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@taikitanaka3 taikitanaka3 merged commit 86a29ae into autowarefoundation:main Aug 25, 2022
@taikitanaka3 taikitanaka3 deleted the feat/add-guard-to-resampling-functions branch August 25, 2022 11:06
taikitanaka3 referenced this pull request in tier4/autoware.universe Aug 26, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* feat(motion_utils): add guard

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(motion_utils): fix problems

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix threshold

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(motion_utils): add guard

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(motion_utils): fix problems

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix threshold

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(motion_utils): add guard

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(motion_utils): fix problems

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix threshold

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
* feat(motion_utils): add guard

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(motion_utils): fix problems

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix threshold

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* feat(motion_utils): add guard

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(motion_utils): fix problems

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix threshold

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants