-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(motion_utils): add guard #1666
feat(motion_utils): add guard #1666
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
…ier4/autoware.universe into feat/add-guard-to-resampling-functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@purewater0901 |
Signed-off-by: yutaka <purewater0901@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1666 +/- ##
==========================================
+ Coverage 10.73% 11.17% +0.44%
==========================================
Files 1103 1103
Lines 78356 79418 +1062
Branches 18649 19577 +928
==========================================
+ Hits 8409 8877 +468
- Misses 61033 61317 +284
- Partials 8914 9224 +310
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* feat(motion_utils): add guard Signed-off-by: yutaka <purewater0901@gmail.com> * feat(motion_utils): fix problems Signed-off-by: yutaka <purewater0901@gmail.com> * fix threshold Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
* feat(motion_utils): add guard Signed-off-by: yutaka <purewater0901@gmail.com> * feat(motion_utils): fix problems Signed-off-by: yutaka <purewater0901@gmail.com> * fix threshold Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
* feat(motion_utils): add guard Signed-off-by: yutaka <purewater0901@gmail.com> * feat(motion_utils): fix problems Signed-off-by: yutaka <purewater0901@gmail.com> * fix threshold Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
* feat(motion_utils): add guard Signed-off-by: yutaka <purewater0901@gmail.com> * feat(motion_utils): fix problems Signed-off-by: yutaka <purewater0901@gmail.com> * fix threshold Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
* feat(motion_utils): add guard Signed-off-by: yutaka <purewater0901@gmail.com> * feat(motion_utils): fix problems Signed-off-by: yutaka <purewater0901@gmail.com> * fix threshold Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka purewater0901@gmail.com
Description
Currently, resampling functions in motion utils do not have guards to prevent them from inserting the same points in input arclength. In this PR, I add a guard to enable the resampling function to avoid having same points.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.