Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tier4_screen_capture_rviz_plugin): apply clang-tidy #1649

Merged

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Aug 22, 2022

Signed-off-by: h-ohta hiroki.ota@tier4.jp

Description

  • apply clang-tidy whose fixed are easy to confirm

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta requested a review from taikitanaka3 August 22, 2022 09:39
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1649 (5b30e50) into main (5b30e50) will not change coverage.
The diff coverage is n/a.

❗ Current head 5b30e50 differs from pull request most recent head 1fddd35. Consider uploading reports for the commit 1fddd35 to get more accurate results

@@           Coverage Diff           @@
##             main    #1649   +/-   ##
=======================================
  Coverage   10.42%   10.42%           
=======================================
  Files        1218     1218           
  Lines       87416    87416           
  Branches    20452    20452           
=======================================
  Hits         9112     9112           
  Misses      68830    68830           
  Partials     9474     9474           
Flag Coverage Δ
total 10.40% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@h-ohta h-ohta force-pushed the refactor/tier4_screen_capture branch from 18c16b3 to a4240bc Compare September 6, 2022 07:33
@h-ohta h-ohta enabled auto-merge (squash) September 6, 2022 07:33
@h-ohta h-ohta changed the title refactor(tier4_screen_capture_rviz_plugin):apply clang-tidy refactor(tier4_screen_capture_rviz_plugin): apply clang-tidy Sep 6, 2022
@h-ohta h-ohta force-pushed the refactor/tier4_screen_capture branch from a4240bc to 72727e6 Compare September 6, 2022 07:36
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
@h-ohta h-ohta force-pushed the refactor/tier4_screen_capture branch from 72727e6 to 1fddd35 Compare September 6, 2022 07:37
@h-ohta h-ohta merged commit 61ac50b into autowarefoundation:main Sep 6, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants