Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_cruise_planner): add velocity_threshold to outside obstacle #1646

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Aug 22, 2022

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

Related Links

tier4/autoware_launch#447

Description

Add min velocity threshold parameter for ignoring slow obstacles outside the trajectory.

This parameter is useful, for example, for filtering slow vehicles on non-priority opossite lanes.
https://user-images.githubusercontent.com/59680180/185863373-be2ec6c9-0146-4b1e-a3d0-fd9e79af74a0.mp4

Note that this parameter also slows down the cut-in response for low-speed vehicles.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…acle

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested a review from takayuki5168 August 22, 2022 07:27
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I'll wait for a launch PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1646 (cee196e) into main (1115898) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1646      +/-   ##
==========================================
- Coverage   10.68%   10.64%   -0.04%     
==========================================
  Files        1109     1109              
  Lines       78629    78871     +242     
  Branches    18592    18592              
==========================================
  Hits         8398     8398              
- Misses      61318    61560     +242     
  Partials     8913     8913              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.66% <0.00%> (ø) Carriedforward from f323228

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/include/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)
...e_planner/include/obstacle_cruise_planner/node.hpp 0.00% <ø> (ø)
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tkimura4 tkimura4 merged commit 27f9216 into autowarefoundation:main Aug 22, 2022
@tkimura4 tkimura4 deleted the feature/vel_thresh_outside_object_to_cruise branch August 22, 2022 08:15
tkimura4 referenced this pull request in tier4/autoware.universe Aug 22, 2022
…acle (#1646)

* feat(obstacle_cruise_planner): add velocity_threshold to outside obstacle

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* add parameter to config

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update readme

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…acle (tier4#1646)

* feat(obstacle_cruise_planner): add velocity_threshold to outside obstacle

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* add parameter to config

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update readme

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…acle (tier4#1646)

* feat(obstacle_cruise_planner): add velocity_threshold to outside obstacle

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* add parameter to config

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update readme

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…acle (tier4#1646)

* feat(obstacle_cruise_planner): add velocity_threshold to outside obstacle

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* add parameter to config

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update readme

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…acle (autowarefoundation#1646)

* feat(obstacle_cruise_planner): add velocity_threshold to outside obstacle

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* add parameter to config

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update readme

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…acle (tier4#1646)

* feat(obstacle_cruise_planner): add velocity_threshold to outside obstacle

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* add parameter to config

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* update readme

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants