Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi_object_tracker): change ekf_params_.use_measurement_covariance to has_covariance #1640

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Aug 19, 2022

Signed-off-by: scepter914 scepter914@gmail.com

Description

Change ekf_params_.use_measurement_covariance to has_covariance.

Related links

Tests performed

Test by rosbag,

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #1640 (b913912) into main (5b60f19) will increase coverage by 0.32%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1640      +/-   ##
==========================================
+ Coverage   10.68%   11.00%   +0.32%     
==========================================
  Files        1109     1040      -69     
  Lines       78588    76328    -2260     
  Branches    18553    18553              
==========================================
+ Hits         8397     8401       +4     
+ Misses      61324    59060    -2264     
  Partials     8867     8867              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.04% <0.00%> (+0.37%) ⬆️ Carriedforward from 685b3a1

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...i_object_tracker/tracker/model/bicycle_tracker.hpp 0.00% <ø> (ø)
...ject_tracker/tracker/model/big_vehicle_tracker.hpp 0.00% <ø> (ø)
...t_tracker/tracker/model/normal_vehicle_tracker.hpp 0.00% <ø> (ø)
...bject_tracker/tracker/model/pedestrian_tracker.hpp 0.00% <ø> (ø)
...i_object_tracker/tracker/model/unknown_tracker.hpp 0.00% <ø> (ø)
...ject_tracker/src/tracker/model/bicycle_tracker.cpp 0.00% <0.00%> (ø)
..._tracker/src/tracker/model/big_vehicle_tracker.cpp 0.00% <0.00%> (ø)
...acker/src/tracker/model/normal_vehicle_tracker.cpp 0.00% <0.00%> (ø)
...t_tracker/src/tracker/model/pedestrian_tracker.cpp 0.00% <0.00%> (ø)
...ject_tracker/src/tracker/model/unknown_tracker.cpp 0.00% <0.00%> (ø)
... and 84 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scepter914 scepter914 changed the title feat(multi_object_tracker): make use_measurement_covariance enable feat(multi_object_tracker): change ekf_params_.use_measurement_covariance to has_covariance Aug 25, 2022
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 marked this pull request as ready for review August 26, 2022 06:40
@scepter914 scepter914 added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 26, 2022
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 merged commit 770fce2 into autowarefoundation:main Aug 27, 2022
@scepter914 scepter914 deleted the feature/enable_use_measurement_covariance branch August 27, 2022 05:24
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…ance to has_covariance (tier4#1640)

* feat(multi_object_tracker): make use_measurement_covariance enable

Signed-off-by: scepter914 <scepter914@gmail.com>

* change ekf_params_.use_measurement_covariance to has_covariance

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ance to has_covariance (tier4#1640)

* feat(multi_object_tracker): make use_measurement_covariance enable

Signed-off-by: scepter914 <scepter914@gmail.com>

* change ekf_params_.use_measurement_covariance to has_covariance

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ance to has_covariance (tier4#1640)

* feat(multi_object_tracker): make use_measurement_covariance enable

Signed-off-by: scepter914 <scepter914@gmail.com>

* change ekf_params_.use_measurement_covariance to has_covariance

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ance to has_covariance (autowarefoundation#1640)

* feat(multi_object_tracker): make use_measurement_covariance enable

Signed-off-by: scepter914 <scepter914@gmail.com>

* change ekf_params_.use_measurement_covariance to has_covariance

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
0x126 referenced this pull request in tier4/autoware.universe Oct 17, 2022
…ance to has_covariance (#1640)

* feat(multi_object_tracker): make use_measurement_covariance enable

Signed-off-by: scepter914 <scepter914@gmail.com>

* change ekf_params_.use_measurement_covariance to has_covariance

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…ance to has_covariance (tier4#1640)

* feat(multi_object_tracker): make use_measurement_covariance enable

Signed-off-by: scepter914 <scepter914@gmail.com>

* change ekf_params_.use_measurement_covariance to has_covariance

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants