refactor(tier4_localization_rviz_plugin): apply clang-tidy #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YamatoAndo
added
the
component:localization
Codecov Report
@@ Coverage Diff @@
## main #1608 +/- ##
==========================================
- Coverage 10.59% 10.58% -0.01%
==========================================
Files 1101 1102 +1
Lines 71856 71883 +27
Branches 17979 17979
==========================================
Hits 7612 7612
- Misses 55803 55830 +27
Partials 8441 8441
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
h-ohta
force-pushed
the
refactor/tier4_localization_rviz_plugin
branch
from
071b90d to
356f478
Compare
h-ohta
force-pushed
the
refactor/tier4_localization_rviz_plugin
branch
from
0110109 to
056ddc4
Compare
common/tier4_localization_rviz_plugin/src/pose_history/pose_history_display.cpp
Outdated
Show resolved
Hide resolved
common/tier4_localization_rviz_plugin/src/pose_history/pose_history_display.hpp
Outdated
Show resolved
Hide resolved
h-ohta
force-pushed
the
refactor/tier4_localization_rviz_plugin
branch
from
056ddc4 to
2191d4e
Compare
isamu-takagi
approved these changes
Aug 19, 2022
| private: | ||
| void subscribe() override; | ||
| void unsubscribe() override; | ||
| void processMessage(const geometry_msgs::msg::PoseStamped::ConstSharedPtr message) override; |
There was a problem hiding this comment.
@h-ohta
[IMO]
I think every function should be lowerCamelCase or snake_case if you want to change this.
other wise this change is worse than before.
There was a problem hiding this comment.
These function are defined in parent class. So I can't change it
There was a problem hiding this comment.
I understand but it looks like strange code style with QT 🤔
if you like this I think it's ok.
4 tasks
boyali
referenced
this pull request
in boyali/autoware.universe
Sep 28, 2022
* refactor(tier4_localization_rviz_plugin): apply clang-tidy * ci(pre-commit): autofix * refactor: add NOLINT * refactor: fix readability-identifier-naming * ci(pre-commit): autofix * fix: build error Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
* refactor(tier4_localization_rviz_plugin): apply clang-tidy * ci(pre-commit): autofix * refactor: add NOLINT * refactor: fix readability-identifier-naming * ci(pre-commit): autofix * fix: build error Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
* refactor(tier4_localization_rviz_plugin): apply clang-tidy * ci(pre-commit): autofix * refactor: add NOLINT * refactor: fix readability-identifier-naming * ci(pre-commit): autofix * fix: build error Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yukke42
pushed a commit
to tzhong518/autoware.universe
that referenced
this pull request
Oct 14, 2022
…oundation#1608) * refactor(tier4_localization_rviz_plugin): apply clang-tidy * ci(pre-commit): autofix * refactor: add NOLINT * refactor: fix readability-identifier-naming * ci(pre-commit): autofix * fix: build error Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 19, 2022
* refactor(tier4_localization_rviz_plugin): apply clang-tidy * ci(pre-commit): autofix * refactor: add NOLINT * refactor: fix readability-identifier-naming * ci(pre-commit): autofix * fix: build error Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.