Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vehicle_info_util): fix wrong image #1548

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Conversation

beyzanurkaya
Copy link
Contributor

@beyzanurkaya beyzanurkaya commented Aug 9, 2022

Description

#1547

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@beyzanurkaya beyzanurkaya force-pushed the 1547-add-correct-image branch 2 times, most recently from cf93c60 to af4d84e Compare August 9, 2022 13:07
Signed-off-by: beyza <bnk@leodrive.ai>
@beyzanurkaya beyzanurkaya force-pushed the 1547-add-correct-image branch from af4d84e to 400edbe Compare August 9, 2022 13:08
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1548 (cf9cedc) into main (51ab335) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1548   +/-   ##
=======================================
  Coverage   10.73%   10.73%           
=======================================
  Files        1115     1115           
  Lines       78815    78815           
  Branches    18560    18560           
=======================================
  Hits         8459     8459           
  Misses      61496    61496           
  Partials     8860     8860           
Flag Coverage Δ *Carryforward flag
differential 9.15% <ø> (?)
total 10.71% <ø> (ø) Carriedforward from 400edbe

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mehmetdogru
Copy link
Contributor

mehmetdogru commented Aug 9, 2022

@beyzanurkaya

please edit .drawio.svg file as a whole using https://app.diagrams.net/

@xmfcx
Copy link
Contributor

xmfcx commented Aug 9, 2022

Can you directly point to the https://autowarefoundation.github.io/autoware-documentation/main/design/autoware-interfaces/components/vehicle-dimensions/ page by removing references to the images?

beyzanurkaya and others added 2 commits August 9, 2022 22:33
Signed-off-by: beyza <bnk@leodrive.ai>
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beyzanurkaya beyzanurkaya merged commit f8b090b into main Aug 10, 2022
@beyzanurkaya beyzanurkaya deleted the 1547-add-correct-image branch August 10, 2022 07:27
kosuke55 referenced this pull request in tier4/autoware.universe Aug 12, 2022
* update image

Signed-off-by: beyza <bnk@leodrive.ai>

* update readme

Signed-off-by: beyza <bnk@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: beyza <bnk@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kosuke55 referenced this pull request in tier4/autoware.universe Aug 13, 2022
* update image

Signed-off-by: beyza <bnk@leodrive.ai>

* update readme

Signed-off-by: beyza <bnk@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: beyza <bnk@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* update image

Signed-off-by: beyza <bnk@leodrive.ai>

* update readme

Signed-off-by: beyza <bnk@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: beyza <bnk@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* update image

Signed-off-by: beyza <bnk@leodrive.ai>

* update readme

Signed-off-by: beyza <bnk@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: beyza <bnk@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* update image

Signed-off-by: beyza <bnk@leodrive.ai>

* update readme

Signed-off-by: beyza <bnk@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: beyza <bnk@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
* update image

Signed-off-by: beyza <bnk@leodrive.ai>

* update readme

Signed-off-by: beyza <bnk@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: beyza <bnk@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* update image

Signed-off-by: beyza <bnk@leodrive.ai>

* update readme

Signed-off-by: beyza <bnk@leodrive.ai>

* ci(pre-commit): autofix

Co-authored-by: beyza <bnk@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants