-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(simple_planning_simulator): fix timer type #1538
fix(simple_planning_simulator): fix timer type #1538
Conversation
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1538 +/- ##
==========================================
- Coverage 10.92% 10.63% -0.29%
==========================================
Files 1037 1111 +74
Lines 69370 78417 +9047
Branches 17832 18403 +571
==========================================
+ Hits 7577 8339 +762
- Misses 53484 61344 +7860
- Partials 8309 8734 +425
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Description
Fix timer in
simple_planning_simulator
to use ros-time correctly.issue to be solved
In the current implementation, due to the timer type in
simple_planning_simulator
, the vehicle motion doesn't move correctly.With
use_sim_time:=true
, the vehicle exceeds the stop line and gets too close to the obstacle in the obstacle-stop scenario.After merging this PR, the vehicle will not exceed the stop line.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.