Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(simple_planning_simulator): fix timer type #1538

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Aug 8, 2022

Description

Fix timer in simple_planning_simulator to use ros-time correctly.

issue to be solved

In the current implementation, due to the timer type in simple_planning_simulator, the vehicle motion doesn't move correctly.

With use_sim_time:=true, the vehicle exceeds the stop line and gets too close to the obstacle in the obstacle-stop scenario.
image

After merging this PR, the vehicle will not exceed the stop line.
image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested a review from tkimura4 August 8, 2022 08:29
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #1538 (f4a5eb8) into main (a9acb3f) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1538      +/-   ##
==========================================
- Coverage   10.92%   10.63%   -0.29%     
==========================================
  Files        1037     1111      +74     
  Lines       69370    78417    +9047     
  Branches    17832    18403     +571     
==========================================
+ Hits         7577     8339     +762     
- Misses      53484    61344    +7860     
- Partials     8309     8734     +425     
Flag Coverage Δ *Carryforward flag
differential 57.03% <0.00%> (?)
total 10.61% <0.00%> (-0.31%) ⬇️ Carriedforward from a9acb3f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nning_simulator/simple_planning_simulator_core.cpp 39.07% <0.00%> (-0.55%) ⬇️
...lude/freespace_planning_algorithms/reeds_shepp.hpp 50.00% <0.00%> (-50.00%) ⬇️
...tic_evaluator/include/kinematic_evaluator/stat.hpp 62.50% <0.00%> (-19.32%) ⬇️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 64.15% <0.00%> (-18.87%) ⬇️
..._evaluator/include/localization_evaluator/stat.hpp 56.25% <0.00%> (-16.48%) ⬇️
.../src/vehicle/test_vehicle_state_checker_helper.hpp 70.58% <0.00%> (-9.42%) ⬇️
planning/behavior_path_planner/test/input.cpp 60.00% <0.00%> (-7.86%) ⬇️
common/perception_utils/src/perception_utils.cpp 56.75% <0.00%> (-6.88%) ⬇️
...include/motion_utils/trajectory/tmp_conversion.hpp 60.00% <0.00%> (-6.67%) ⬇️
...oware_auto_geometry/include/geometry/common_2d.hpp 82.66% <0.00%> (-5.91%) ⬇️
... and 763 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I confirmed ego doesn't exceed stop line
image

2022-08-10-13-22-42.mp4

@TakaHoribe TakaHoribe merged commit b087957 into autowarefoundation:main Aug 10, 2022
@TakaHoribe TakaHoribe deleted the fix/simple-planning-sim-timer branch August 10, 2022 06:21
kosuke55 referenced this pull request in tier4/autoware.universe Aug 12, 2022
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
kosuke55 referenced this pull request in tier4/autoware.universe Aug 13, 2022
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants