Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): fix goal velocity #1497

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Aug 2, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Change terminal velocity by using zero-order hold instead of using linear interpolation

image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This PR might affect motion velocity smoother's velocity 1m around goal position

purewater0901 and others added 2 commits August 2, 2022 18:10
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #1497 (5e4bcc9) into main (05f6a6b) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1497      +/-   ##
==========================================
- Coverage   10.36%   10.31%   -0.06%     
==========================================
  Files        1135     1135              
  Lines       79574    80028     +454     
  Branches    18534    18873     +339     
==========================================
  Hits         8251     8251              
- Misses      63122    63533     +411     
- Partials     8201     8244      +43     
Flag Coverage Δ *Carryforward flag
differential 0.79% <0.00%> (?)
total 10.35% <0.00%> (ø) Carriedforward from e64b2ff

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 0.81% <0.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ae23e...5e4bcc9. Read the comment docs.

@purewater0901 purewater0901 merged commit 2be2ca3 into autowarefoundation:main Aug 2, 2022
@purewater0901 purewater0901 deleted the fix/goal-velocity branch August 2, 2022 10:23
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* feat(behavior_path_planner): fix goal velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* remove unnessary variables

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(behavior_path_planner): fix goal velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* remove unnessary variables

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(behavior_path_planner): fix goal velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* remove unnessary variables

Signed-off-by: yutaka <purewater0901@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
* feat(behavior_path_planner): fix goal velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* remove unnessary variables

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* feat(behavior_path_planner): fix goal velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* remove unnessary variables

Signed-off-by: yutaka <purewater0901@gmail.com>
h-ohta referenced this pull request in tier4/autoware.universe May 24, 2023
* feat(behavior_path_planner): fix goal velocity

Signed-off-by: yutaka <purewater0901@gmail.com>

* remove unnessary variables

Signed-off-by: yutaka <purewater0901@gmail.com>
h-ohta referenced this pull request in tier4/autoware.universe Jun 27, 2023
feat(behavior_path_planner): fix goal velocity (#1497)

* feat(behavior_path_planner): fix goal velocity



* remove unnessary variables

Signed-off-by: yutaka <purewater0901@gmail.com>
Co-authored-by: Yutaka Shimizu <43805014+purewater0901@users.noreply.github.com>
yhisaki pushed a commit to yhisaki/autoware.universe that referenced this pull request Sep 5, 2024
… processing based on source (autowarefoundation#1497)

feat(autoware_accel_brake_map_calibrator): conditional actuation data processing based on source (autowarefoundation#8593)

* fix: Conditional Actuation Data Processing Based on Source



* style(pre-commit): autofix

* delete extra comentout, indent



* add take validation



* style(pre-commit): autofix

---------

Signed-off-by: N-Eiki <eiki.nagata.2@tier4.jp>
Co-authored-by: eiki <53928021+N-Eiki@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants