-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): fix goal velocity #1497
feat(behavior_path_planner): fix goal velocity #1497
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR might affect motion velocity smoother's velocity 1m around goal position
Signed-off-by: yutaka <purewater0901@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1497 +/- ##
==========================================
- Coverage 10.36% 10.31% -0.06%
==========================================
Files 1135 1135
Lines 79574 80028 +454
Branches 18534 18873 +339
==========================================
Hits 8251 8251
- Misses 63122 63533 +411
- Partials 8201 8244 +43
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
* feat(behavior_path_planner): fix goal velocity Signed-off-by: yutaka <purewater0901@gmail.com> * remove unnessary variables Signed-off-by: yutaka <purewater0901@gmail.com>
* feat(behavior_path_planner): fix goal velocity Signed-off-by: yutaka <purewater0901@gmail.com> * remove unnessary variables Signed-off-by: yutaka <purewater0901@gmail.com>
* feat(behavior_path_planner): fix goal velocity Signed-off-by: yutaka <purewater0901@gmail.com> * remove unnessary variables Signed-off-by: yutaka <purewater0901@gmail.com>
* feat(behavior_path_planner): fix goal velocity Signed-off-by: yutaka <purewater0901@gmail.com> * remove unnessary variables Signed-off-by: yutaka <purewater0901@gmail.com>
* feat(behavior_path_planner): fix goal velocity Signed-off-by: yutaka <purewater0901@gmail.com> * remove unnessary variables Signed-off-by: yutaka <purewater0901@gmail.com>
* feat(behavior_path_planner): fix goal velocity Signed-off-by: yutaka <purewater0901@gmail.com> * remove unnessary variables Signed-off-by: yutaka <purewater0901@gmail.com>
feat(behavior_path_planner): fix goal velocity (#1497) * feat(behavior_path_planner): fix goal velocity * remove unnessary variables Signed-off-by: yutaka <purewater0901@gmail.com> Co-authored-by: Yutaka Shimizu <43805014+purewater0901@users.noreply.github.com>
… processing based on source (autowarefoundation#1497) feat(autoware_accel_brake_map_calibrator): conditional actuation data processing based on source (autowarefoundation#8593) * fix: Conditional Actuation Data Processing Based on Source * style(pre-commit): autofix * delete extra comentout, indent * add take validation * style(pre-commit): autofix --------- Signed-off-by: N-Eiki <eiki.nagata.2@tier4.jp> Co-authored-by: eiki <53928021+N-Eiki@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: yutaka purewater0901@gmail.com
Description
Change terminal velocity by using zero-order hold instead of using linear interpolation
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.