-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rviz_plugin): fix screen capture plugin #1492
Conversation
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Codecov Report
@@ Coverage Diff @@
## main #1492 +/- ##
==========================================
- Coverage 10.37% 10.36% -0.01%
==========================================
Files 1135 1135
Lines 79575 79611 +36
Branches 18549 18549
==========================================
Hits 8254 8254
- Misses 63107 63143 +36
Partials 8214 8214
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 ttatcoder@outlook.jp
Description
resolve #1491
fix setting empty filename before updating
check to capture screen and see files
note: capture/1970-01-01-09-00-41.mp4 is created with simulation time
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.