Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(obstacle_stop_planner): prevent unnecessary duplicate points #1486

Conversation

maxime-clem
Copy link
Contributor

Signed-off-by: Maxime CLEMENT maxime.clement@tier4.jp

Description

This PR improve performance of function searchPointcloudNearTrajectory() used to filter a pointcloud and keep only points close enough to a trajectory.

In the current implementation, a point from the pointcloud will be added for all trajectory point that are within range.
This PR ensures that a point can only be added once.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem maxime-clem added type:new-feature New functionalities or additions, feature requests. component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Aug 1, 2022
@maxime-clem maxime-clem self-assigned this Aug 1, 2022
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #1486 (7b94ead) into main (38a3c60) will increase coverage by 0.43%.
The diff coverage is n/a.

❗ Current head 7b94ead differs from pull request most recent head bce2598. Consider uploading reports for the commit bce2598 to get more accurate results

@@            Coverage Diff             @@
##             main    #1486      +/-   ##
==========================================
+ Coverage   10.28%   10.72%   +0.43%     
==========================================
  Files        1205     1103     -102     
  Lines       86829    78410    -8419     
  Branches    20079    18649    -1430     
==========================================
- Hits         8931     8409     -522     
+ Misses      68602    61087    -7515     
+ Partials     9296     8914     -382     
Flag Coverage Δ
total 10.70% <0.00%> (+0.43%) ⬆️
Impacted Files Coverage Δ
...ail/dds_fastrtps/response_status__type_support.cpp 0.00% <0.00%> (-16.08%) ⬇️
..._msgs/msg/detail/response_status__type_support.cpp 0.00% <0.00%> (-15.39%) ⬇️
...city_planner/include/utilization/arc_lane_util.hpp 32.75% <0.00%> (-15.13%) ⬇️
planning/behavior_path_planner/src/utilities.cpp 1.04% <0.00%> (-2.32%) ⬇️
...planning_evaluator/src/planning_evaluator_node.cpp 37.11% <0.00%> (-1.04%) ⬇️
...ils/include/motion_utils/trajectory/trajectory.hpp 77.86% <0.00%> (-0.89%) ⬇️
...ner/src/scene_module/avoidance/avoidance_utils.cpp 2.91% <0.00%> (-0.22%) ⬇️
.../motion_velocity_smoother/src/trajectory_utils.cpp 3.24% <0.00%> (-0.13%) ⬇️
system/default_ad_api/src/interface.cpp 71.42% <0.00%> (ø)
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
... and 190 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@maxime-clem maxime-clem force-pushed the perf-obstacle_stop_planner-searchPointcloudNearTrajectory branch 2 times, most recently from 3967174 to aa70d95 Compare August 13, 2022 07:53
@maxime-clem maxime-clem force-pushed the perf-obstacle_stop_planner-searchPointcloudNearTrajectory branch 2 times, most recently from c5de73b to 829f210 Compare August 24, 2022 11:13
…ectory

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the perf-obstacle_stop_planner-searchPointcloudNearTrajectory branch from 829f210 to bce2598 Compare August 31, 2022 01:23
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxime-clem maxime-clem merged commit a7b19c3 into autowarefoundation:main Aug 31, 2022
@maxime-clem maxime-clem deleted the perf-obstacle_stop_planner-searchPointcloudNearTrajectory branch August 31, 2022 11:58
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…er4#1486)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…er4#1486)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…er4#1486)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…er4#1486)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
yhisaki pushed a commit to yhisaki/autoware.universe that referenced this pull request Sep 5, 2024
…_thread_0.29

fix(goal_planner): remove time keeper in non main thread (autowarefoundation#8610)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants