fix(behavior_path_planner): fix unnecessary output of behavior_path_planner #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jack.song <jack.song@autocore.ai>
Signed-off-by: jack.song <jack.song@autocore.ai>
taikitanaka3
reviewed
Aug 1, 2022
| @@ -2159,6 +2159,7 @@ CandidateOutput AvoidanceModule::planCandidate() const | |||
| { | |||
| DEBUG_PRINT("AVOIDANCE planCandidate start"); | |||
| CandidateOutput output; | |||
| output.distance_to_path_change = 0.0; | |||
There was a problem hiding this comment.
@shulanbushangshu
I think this line is not necessary.
because distance_to_path_change is initialized by {std::numeric_limits::lowest()}
Codecov Report
@@ Coverage Diff @@
## main #1481 +/- ##
==========================================
+ Coverage 10.18% 10.38% +0.20%
==========================================
Files 1135 1059 -76
Lines 78538 69873 -8665
Branches 17891 17437 -454
==========================================
- Hits 7998 7257 -741
+ Misses 62922 55259 -7663
+ Partials 7618 7357 -261
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
|
@rej55 COuld you please check this PR? This is related to the RTC function. |
TakaHoribe
added
the
component:planning
|
@shulanbushangshu |
saka1-s
pushed a commit
to saka1-s/autoware.universe
that referenced
this pull request
Aug 21, 2024
…d_gate_check_cmd_continuity feat(autoware_vehicle_cmd_gate): check the timestamp of input topics to avoid using old topics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add conditions to limit unnecessary output without new obstacle avoidance information
Related links
#1476
Tests performed
simulation after adding conditions:
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.