Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(behavior_velocity): parameterlize detection area length #1346

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Jul 14, 2022

Signed-off-by: tanaka3 ttatcoder@outlook.jp

Description

parameterize detection area length, this is to prevent chattering from the difference between planned and measured acc.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 requested review from mkuri and 0x126 July 14, 2022 07:55
@taikitanaka3 taikitanaka3 marked this pull request as ready for review July 14, 2022 08:08
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1346 (6553e69) into main (ddf5c54) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1346      +/-   ##
========================================
- Coverage   9.47%   9.39%   -0.08%     
========================================
  Files       1114    1114              
  Lines      76677   77863    +1186     
  Branches   16622   17434     +812     
========================================
+ Hits        7264    7317      +53     
- Misses     62785   63798    +1013     
- Partials    6628    6748     +120     
Flag Coverage Δ *Carryforward flag
differential 4.94% <0.00%> (?)
total 9.45% <0.00%> (ø) Carriedforward from ddf5c54

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ene_module/occlusion_spot/occlusion_spot_utils.hpp 45.45% <ø> (-11.69%) ⬇️
...lanner/src/scene_module/occlusion_spot/manager.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/scene_occlusion_spot.cpp 0.00% <0.00%> (ø)
...elocity_planner/src/scene_module/run_out/debug.cpp 0.00% <0.00%> (ø)
...elocity_planner/src/scene_module/run_out/utils.cpp 0.00% <0.00%> (ø)
...ocity_planner/src/scene_module/crosswalk/debug.cpp 0.00% <0.00%> (ø)
...ocity_planner/src/scene_module/stop_line/debug.cpp 0.00% <0.00%> (ø)
...city_planner/src/scene_module/blind_spot/debug.cpp 0.00% <0.00%> (ø)
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddf5c54...6553e69. Read the comment docs.

Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit 8190729 into autowarefoundation:main Jul 22, 2022
taikitanaka3 referenced this pull request in tier4/autoware.universe Jul 22, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
taikitanaka3 referenced this pull request in tier4/autoware.universe Aug 8, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@taikitanaka3 taikitanaka3 deleted the chore/occlusion_spot_parameterize branch January 9, 2023 04:20
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Jul 2, 2024
feat(diagnostic_graph_utils): add logging tool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants