Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(closest_velocity_checker): fix qos transient local #1338

Merged

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Jul 13, 2022

Signed-off-by: taikitanaka3 ttatcoder@outlook.jp

Description

before
image

after
image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3 taikitanaka3 requested review from shmpwk and tkimura4 July 13, 2022 08:16
@taikitanaka3 taikitanaka3 marked this pull request as ready for review July 13, 2022 08:18
@taikitanaka3 taikitanaka3 force-pushed the fix/qos_closest_vel_check branch from e8e8ad6 to 61c980c Compare July 13, 2022 08:30
@taikitanaka3 taikitanaka3 reopened this Jul 13, 2022
@taikitanaka3 taikitanaka3 enabled auto-merge (squash) July 13, 2022 08:42
@taikitanaka3 taikitanaka3 force-pushed the fix/qos_closest_vel_check branch from 0e62a40 to 2ae0d16 Compare July 13, 2022 09:03
@taikitanaka3
Copy link
Contributor Author

@kenji-miyake
Do you have any idea why CI is not running now?

@kenji-miyake
Copy link
Contributor

@taikitanaka3 There are too many jobs running now, so please wait for a while. 🙏

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #1338 (0e62a40) into main (6ebc85e) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 0e62a40 differs from pull request most recent head 2ae0d16. Consider uploading reports for the commit 2ae0d16 to get more accurate results

@@           Coverage Diff            @@
##            main   #1338      +/-   ##
========================================
- Coverage   9.53%   9.51%   -0.03%     
========================================
  Files       1096    1096              
  Lines      76578   76802     +224     
  Branches   17222   17391     +169     
========================================
+ Hits        7304    7310       +6     
- Misses     62460   62669     +209     
- Partials    6814    6823       +9     
Flag Coverage Δ *Carryforward flag
differential 3.88% <ø> (?)
total 9.53% <ø> (+0.01%) ⬆️ Carriedforward from 61c980c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...behavior_velocity_planner/src/utilization/util.cpp 21.90% <0.00%> (-1.06%) ⬇️
...vior_velocity_planner/include/utilization/util.hpp 3.57% <0.00%> (-0.49%) ⬇️
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/crosswalk/manager.cpp 0.00% <0.00%> (ø)
..._planner/include/obstacle_cruise_planner/utils.hpp 0.00% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
.../src/scene_module/side_shift/side_shift_module.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/crosswalk/scene_crosswalk.cpp 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ebc85e...2ae0d16. Read the comment docs.

@taikitanaka3 taikitanaka3 merged commit 7c4d1e8 into autowarefoundation:main Jul 13, 2022
@taikitanaka3 taikitanaka3 mentioned this pull request Jul 14, 2022
3 tasks
taikitanaka3 referenced this pull request in tier4/autoware.universe Jul 14, 2022
* fix(closest_velocity_checker): fix qos transient local

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* chore: reduce diff

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
taikitanaka3 referenced this pull request in tier4/autoware.universe Jul 15, 2022
* fix(closest_velocity_checker): fix qos transient local

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* chore: reduce diff

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* fix(closest_velocity_checker): fix qos transient local

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* chore: reduce diff

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* fix(closest_velocity_checker): fix qos transient local

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* chore: reduce diff

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* fix(closest_velocity_checker): fix qos transient local

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* chore: reduce diff

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ation#1338)

* fix(closest_velocity_checker): fix qos transient local

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* chore: reduce diff

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* fix(closest_velocity_checker): fix qos transient local

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* chore: reduce diff

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@taikitanaka3 taikitanaka3 deleted the fix/qos_closest_vel_check branch January 9, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants