Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tier4_perception_launch): add object filter params to tier4_perception_launch #1322

Merged
merged 3 commits into from
Jul 12, 2022
Merged

feat(tier4_perception_launch): add object filter params to tier4_perception_launch #1322

merged 3 commits into from
Jul 12, 2022

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Jul 12, 2022 •
edited
Loading

Signed-off-by: Shunsuke Miura shunsuke.miura@tier4.jp

Description

Add config parameters introduced in #1221 to tier4_perception_launch

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@miursh
Add params to tier4_perception_launch
ef25932 
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh miursh requested review from yukke42 and yukkysaito July 12, 2022 11:05
@miursh miursh marked this pull request as ready for review July 12, 2022 11:05
@miursh miursh enabled auto-merge (squash) July 12, 2022 12:15
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1322 (6630321) into main (db01212) will not change coverage.
The diff coverage is n/a.

❗ Current head 6630321 differs from pull request most recent head 6a64d1e. Consider uploading reports for the commit 6a64d1e to get more accurate results

@@          Coverage Diff          @@
##            main   #1322   +/-   ##
=====================================
  Coverage   9.51%   9.51%           
=====================================
  Files       1096    1096           
  Lines      76148   76148           
  Branches   16991   16991           
=====================================
  Hits        7244    7244           
  Misses     62292   62292           
  Partials    6612    6612
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 9.49% <ø> (ø) Carriedforward from ef25932

*This pull request uses carry forward flags. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a5418...6a64d1e. Read the comment docs.

@miursh miursh merged commit 74427a8 into autowarefoundation:main Jul 12, 2022
@miursh miursh deleted the fix/object_filter_config branch July 12, 2022 17:10
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 13, 2022
Merged
kosuke55 referenced this pull request in tier4/autoware.universe Jul 14, 2022
@miursh @pre-commit-ci @kosuke55
feat(tier4_perception_launch): add object filter params to tier4_perc…
8749b92 
…eption_launch (#1322)

* Add params to tier4_perception_launch

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yukke42 referenced this pull request in tier4/autoware.universe Aug 9, 2022
@miursh @pre-commit-ci @yukke42
feat(tier4_perception_launch): add object filter params to tier4_perc…
4bc0fe9 
…eption_launch (#1322)

* Add params to tier4_perception_launch

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@miursh @pre-commit-ci @boyali
feat(tier4_perception_launch): add object filter params to tier4_perc…
d82aff5 
…eption_launch (tier4#1322)

* Add params to tier4_perception_launch

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@miursh @pre-commit-ci @boyali
feat(tier4_perception_launch): add object filter params to tier4_perc…
2f9a088 
…eption_launch (tier4#1322)

* Add params to tier4_perception_launch

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@miursh @pre-commit-ci @boyali
feat(tier4_perception_launch): add object filter params to tier4_perc…
21c9ec7 
…eption_launch (tier4#1322)

* Add params to tier4_perception_launch

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 7, 2022
@miursh @pre-commit-ci @1222-takeshi
feat(tier4_perception_launch): add object filter params to tier4_perc…
607536e 
…eption_launch (#1322)

* Add params to tier4_perception_launch

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@1222-takeshi 1222-takeshi mentioned this pull request Oct 7, 2022
Merged
4 tasks
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 7, 2022
@miursh @pre-commit-ci @1222-takeshi
feat(tier4_perception_launch): add object filter params to tier4_perc…
36916ef 
…eption_launch (#1322)

* Add params to tier4_perception_launch

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@miursh @pre-commit-ci
feat(tier4_perception_launch): add object filter params to tier4_perc…
6e58b66 
…eption_launch (autowarefoundation#1322)

* Add params to tier4_perception_launch

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@miursh @pre-commit-ci @boyali
feat(tier4_perception_launch): add object filter params to tier4_perc…
0d1d7e0 
…eption_launch (tier4#1322)

* Add params to tier4_perception_launch

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 16, 2023
@miursh @pre-commit-ci @satoshi-ota
feat(tier4_perception_launch): add object filter params to tier4_perc…
eba4dbb 
…eption_launch (autowarefoundation#1322)

* Add params to tier4_perception_launch

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 2, 2023
@miursh @pre-commit-ci @badai-nguyen
feat(tier4_perception_launch): add object filter params to tier4_perc…
ee209fb 
…eption_launch (autowarefoundation#1322)

* Add params to tier4_perception_launch

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Jun 12, 2024
@technolojin
fix(multi_object_tracker): mot convexhull to bbox convert bug (autowa…
4c71844 
…refoundation#1322)

* fix: fix a bug of convertConvexHullToBoundingBox

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* fix: clang format

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@yukke42 yukke42 Awaiting requested review from yukke42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miursh @yukkysaito