Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_planning_launch): add group tag #1239

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

angry-crab
Copy link
Contributor

@angry-crab angry-crab commented Jul 5, 2022

Signed-off-by: Xinyu Wang xinyu.wang@tier4.jp

Description

Add group tag to launch files.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #1239 (2dbe02b) into main (27e2664) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 2dbe02b differs from pull request most recent head 896f678. Consider uploading reports for the commit 896f678 to get more accurate results

@@           Coverage Diff            @@
##            main   #1239      +/-   ##
========================================
- Coverage   9.54%   9.52%   -0.02%     
========================================
  Files       1096    1051      -45     
  Lines      76557   72465    -4092     
  Branches   17207   15776    -1431     
========================================
- Hits        7310    6905     -405     
+ Misses     62435   59280    -3155     
+ Partials    6812    6280     -532     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 9.51% <ø> (-0.03%) ⬇️ Carriedforward from a053a9d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ator/nodes/costmap_generator/points_to_costmap.cpp 0.00% <0.00%> (-82.36%) ⬇️
...include/tier4_autoware_utils/geometry/geometry.hpp 86.66% <0.00%> (-4.38%) ⬇️
...ulator/vehicle_model/sim_model_ideal_steer_acc.cpp 91.66% <0.00%> (-4.17%) ⬇️
...ulator/vehicle_model/sim_model_ideal_steer_vel.cpp 92.30% <0.00%> (-3.85%) ⬇️
...autoware_utils/test/src/geometry/test_geometry.cpp 37.59% <0.00%> (-2.99%) ⬇️
control/trajectory_follower/src/mpc.cpp 46.17% <0.00%> (-2.69%) ⬇️
.../trajectory_follower_nodes/src/controller_node.cpp 42.18% <0.00%> (-2.43%) ⬇️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 71.69% <0.00%> (-1.89%) ⬇️
...te/include/vehicle_cmd_gate/vehicle_cmd_filter.hpp 85.71% <0.00%> (-1.79%) ⬇️
...ulator/vehicle_model/sim_model_delay_steer_acc.cpp 78.33% <0.00%> (-1.67%) ⬇️
... and 156 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 910d6c8...896f678. Read the comment docs.

@angry-crab angry-crab requested a review from h-ohta July 12, 2022 02:56
angry-crab and others added 2 commits July 12, 2022 12:02
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
@angry-crab angry-crab requested a review from h-ohta July 12, 2022 04:57
@angry-crab angry-crab enabled auto-merge (squash) July 13, 2022 05:58
@angry-crab angry-crab merged commit 6ebc85e into autowarefoundation:main Jul 13, 2022
@angry-crab angry-crab deleted the fix_planning_launch branch July 13, 2022 08:42
kosuke55 referenced this pull request in tier4/autoware.universe Jul 14, 2022
* fix(tier4_planning_launch): add group tag

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* move arg

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* move arg inside group

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* fix(tier4_planning_launch): add group tag

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* move arg

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* move arg inside group

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* fix(tier4_planning_launch): add group tag

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* move arg

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* move arg inside group

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* fix(tier4_planning_launch): add group tag

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* move arg

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* move arg inside group

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
* fix(tier4_planning_launch): add group tag

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* move arg

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* move arg inside group

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* fix(tier4_planning_launch): add group tag

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* move arg

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* move arg inside group

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants