Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launch): add group tag to launch files #1210

Conversation

angry-crab
Copy link
Contributor

Signed-off-by: Xinyu Wang xinyu.wang@tier4.jp

Description

Add group tag around include files

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
@h-ohta
Copy link
Contributor

h-ohta commented Jul 1, 2022

@angry-crab Could you separate this PR by tier4_xxx_launch? It could be easier to review.

@angry-crab angry-crab closed this Jul 5, 2022
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 27, 2024
…ane change (autowarefoundation#1210)

fix(out_of_lane): calculate path lanelets that we can miss during a lane change (autowarefoundation#6600)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<arg> is overwritten when including multiple launch files because <include> does not scope
2 participants