fix(mission_planner): align goal pose to lanelet map #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #1129 +/- ##
========================================
- Coverage 9.52% 9.51% -0.01%
========================================
Files 1051 1051
Lines 72452 72508 +56
Branches 15776 15776
========================================
Hits 6899 6899
- Misses 59538 59594 +56
Partials 6015 6015
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
mitsudome-r
reviewed
Jun 29, 2022
planning/mission_planner/src/mission_planner_lanelet2/mission_planner_lanelet2.cpp
Outdated
Show resolved
Hide resolved
mitsudome-r
reviewed
Jun 29, 2022
planning/mission_planner/src/mission_planner_lanelet2/mission_planner_lanelet2.cpp
Show resolved
Hide resolved
|
I can confirm that the goal pose is on the map with this fix. In main commit it was ~50m under the map. |
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
xmfcx
force-pushed
the
711-goal-pose-is-not-aligned-to-the-map
branch
from
ac8afb9 to
d1731e1
Compare
|
The code changes are minimal and on point. I've rebased it to main and once CI is finished, it should be merged. |
xmfcx
approved these changes
Jul 4, 2022
boyali
referenced
this pull request
in boyali/autoware.universe
Sep 28, 2022
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
yukke42
pushed a commit
to tzhong518/autoware.universe
that referenced
this pull request
Oct 14, 2022
…ion#1129) Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 19, 2022
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
takam5f2
pushed a commit
to takam5f2/autoware.universe
that referenced
this pull request
Feb 8, 2024
…avoidance fix(avoidance): cherry pick
iwatake2222
pushed a commit
to iwatake2222/autoware.universe
that referenced
this pull request
Jan 17, 2025
…towarefoundation#1129) Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai> Signed-off-by: beyza <bnk@leodrive.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xinyu Wang xinyu.wang@tier4.jp
Description
Goal pose is aligned to lanelet map by calculating an average height of each segment from the closest lanelet component.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.