-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_autoware_utils): add new calcSignedArclength Function #1092
feat(tier4_autoware_utils): add new calcSignedArclength Function #1092
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave the review to @takayuki5168 -san!
Codecov Report
@@ Coverage Diff @@
## main #1092 +/- ##
========================================
+ Coverage 8.98% 9.04% +0.05%
========================================
Files 1024 1025 +1
Lines 69428 69977 +549
Branches 11696 11821 +125
========================================
+ Hits 6238 6329 +91
- Misses 58090 58490 +400
- Partials 5100 5158 +58
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
*/ | ||
template <class T> | ||
boost::optional<double> calcSignedArcLength( | ||
const T & points, const geometry_msgs::msg::Pose & src_pose, const size_t & dst_idx, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reference is not required for size_t
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: yutaka <purewater0901@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…owarefoundation#1092) * feat(tier4_autoware_utils): add new calcSignedArclength Function Signed-off-by: yutaka <purewater0901@gmail.com> * fix argument Signed-off-by: yutaka <purewater0901@gmail.com> Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
…owarefoundation#1092) * feat(tier4_autoware_utils): add new calcSignedArclength Function Signed-off-by: yutaka <purewater0901@gmail.com> * fix argument Signed-off-by: yutaka <purewater0901@gmail.com>
…r4#1092) * feat(tier4_autoware_utils): add new calcSignedArclength Function Signed-off-by: yutaka <purewater0901@gmail.com> * fix argument Signed-off-by: yutaka <purewater0901@gmail.com>
…r4#1092) * feat(tier4_autoware_utils): add new calcSignedArclength Function Signed-off-by: yutaka <purewater0901@gmail.com> * fix argument Signed-off-by: yutaka <purewater0901@gmail.com>
…r4#1092) * feat(tier4_autoware_utils): add new calcSignedArclength Function Signed-off-by: yutaka <purewater0901@gmail.com> * fix argument Signed-off-by: yutaka <purewater0901@gmail.com>
…r4#1092) * feat(tier4_autoware_utils): add new calcSignedArclength Function Signed-off-by: yutaka <purewater0901@gmail.com> * fix argument Signed-off-by: yutaka <purewater0901@gmail.com>
…r4#1092) * feat(tier4_autoware_utils): add new calcSignedArclength Function Signed-off-by: yutaka <purewater0901@gmail.com> * fix argument Signed-off-by: yutaka <purewater0901@gmail.com>
…start_planner feat(start_planner): cherry pick
…utowarefoundation#1092) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: yutaka purewater0901@gmail.com
Description
Add new calc signed arc function which has distance and yaw threshold.
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.