-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_velocity): use pose for min velocity if the object is stopped #1052
fix(behavior_velocity): use pose for min velocity if the object is stopped #1052
Conversation
…opped Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Codecov Report
@@ Coverage Diff @@
## main #1052 +/- ##
========================================
- Coverage 9.21% 9.01% -0.21%
========================================
Files 1010 1010
Lines 65516 69015 +3499
Branches 11380 11861 +481
========================================
+ Hits 6039 6223 +184
- Misses 54482 57585 +3103
- Partials 4995 5207 +212
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
oh, thanks! I fixed. 26a63fd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…opped (autowarefoundation#1052) * fix(behavior_velocity): use pose for min velocity if the object is stopped Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix typo Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…opped (autowarefoundation#1052) * fix(behavior_velocity): use pose for min velocity if the object is stopped Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix typo Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
…opped (autowarefoundation#1052) * fix(behavior_velocity): use pose for min velocity if the object is stopped Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix typo Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…opped (tier4#1052) * fix(behavior_velocity): use pose for min velocity if the object is stopped Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix typo Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…opped (tier4#1052) * fix(behavior_velocity): use pose for min velocity if the object is stopped Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix typo Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…opped (tier4#1052) * fix(behavior_velocity): use pose for min velocity if the object is stopped Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix typo Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…opped (tier4#1052) * fix(behavior_velocity): use pose for min velocity if the object is stopped Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix typo Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…opped (tier4#1052) * fix(behavior_velocity): use pose for min velocity if the object is stopped Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * fix typo Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…ndation#5718) (autowarefoundation#1052) * fix(path_smoother): faster elastic band by sparse matrix * fix typo --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…ndation#5718) (autowarefoundation#1052) * fix(path_smoother): faster elastic band by sparse matrix * fix typo --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Tomohito Ando tomohito.ando@tier4.jp
Description
before this PR
Orientation of the obstacle was wrong and the obstacle beside the pass was considered to be collision.
after this PR
Orientation of the obstacle has been fixed.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.