Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add twist information for detected object on rviz #1014

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Jun 1, 2022

Description

Add twist information for detected object on rviz.

Screenshot from 2022-05-31 00-39-22

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1014 (07831cd) into main (097ec8e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1014      +/-   ##
========================================
- Coverage   9.71%   9.71%   -0.01%     
========================================
  Files        953     953              
  Lines      64011   64022      +11     
  Branches   11181   11181              
========================================
  Hits        6217    6217              
- Misses     52631   52642      +11     
  Partials    5163    5163              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.69% <0.00%> (ø) Carriedforward from 097ec8e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../src/object_detection/detected_objects_display.cpp 0.00% <0.00%> (ø)
...src/object_detection/predicted_objects_display.cpp 0.00% <0.00%> (ø)
...n/src/object_detection/tracked_objects_display.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 097ec8e...07831cd. Read the comment docs.

@scepter914 scepter914 changed the title Feature/rviz detected object twist feat: rviz detected object twist Jun 1, 2022
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 force-pushed the feature/rviz_detected_object_twist branch from bef6dfc to 07831cd Compare June 1, 2022 07:02
@scepter914 scepter914 marked this pull request as ready for review June 1, 2022 07:12
@scepter914 scepter914 requested review from aohsato and miursh June 1, 2022 07:12
@scepter914 scepter914 changed the title feat: rviz detected object twist feat: add twist information for detected object on rviz Jun 1, 2022
Comment on lines +57 to +58
uuid_vis_position.x = object.kinematics.initial_pose_with_covariance.pose.position.x;
uuid_vis_position.y = object.kinematics.initial_pose_with_covariance.pose.position.y - 0.5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scepter914 Can you share the image taken from view point of a third person?
I think it's good from BEV, but from view point of a third person it would be out of alignment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be better to merge into one string and publish

@scepter914
Copy link
Contributor Author

Time has passed, so I will issue another PR.

@scepter914 scepter914 closed this Jul 11, 2022
@scepter914 scepter914 deleted the feature/rviz_detected_object_twist branch July 11, 2022 09:13
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Nov 29, 2023
…d0804

fix(avoidance): fix a bug regarding the nearest search (autowarefoundation#5575)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants