Skip to content

Commit

Permalink
ci(build): don't skip jobs even if the targets are empty (#61)
Browse files Browse the repository at this point in the history
Skipped jobs cannot be set to required.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
  • Loading branch information
kenji-miyake authored Dec 1, 2021
1 parent 40be0c8 commit 09ff1bf
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/build-and-test-pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ jobs:

build-and-test:
needs: get-modified-packages
if: ${{ needs.get-modified-packages.outputs.modified-packages != '' }}
uses: autowarefoundation/autoware-github-actions/.github/workflows/reusable-colcon-build-and-test.yaml@tier4/proposal
with:
rosdistro: galactic
Expand All @@ -23,7 +22,6 @@ jobs:

clang-tidy:
needs: [get-modified-source-files, build-and-test]
if: ${{ needs.get-modified-source-files.outputs.modified-source-files != '' }}
uses: autowarefoundation/autoware-github-actions/.github/workflows/reusable-clang-tidy.yaml@tier4/proposal
with:
script-ref: tier4/proposal
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/build-and-test-scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ jobs:

build-and-test:
needs: get-self-packages
if: ${{ needs.get-self-packages.outputs.self-packages != '' }}
uses: autowarefoundation/autoware-github-actions/.github/workflows/reusable-colcon-build-and-test.yaml@tier4/proposal
with:
rosdistro: galactic
Expand All @@ -20,7 +19,6 @@ jobs:

build-and-test-arm64:
needs: get-self-packages
if: ${{ needs.get-self-packages.outputs.self-packages != '' }}
uses: autowarefoundation/autoware-github-actions/.github/workflows/reusable-colcon-build-and-test.yaml@tier4/proposal
with:
os: ARM64
Expand Down

0 comments on commit 09ff1bf

Please sign in to comment.