Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(how-to-guides): add instructions for sensor calibration #145

Merged
5 commits merged into from
Jun 20, 2022

Conversation

mitsudome-r
Copy link
Member

Signed-off-by: mitsudome-r ryohsuke.mitsudome@tier4.jp

Description

Add how-to-guides for sensor calibration.
Related issue: autowarefoundation/autoware.universe#679

This PR is meant to create a page for sensor calibration so that members of AWF can start adding their calibration tools.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

mitsudome-r and others added 2 commits June 15, 2022 00:04
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor fixes suggested, mostly to change titles to use sentence case.

docs/how-to-guides/sensor-calibration.md Outdated Show resolved Hide resolved
docs/how-to-guides/sensor-calibration.md Outdated Show resolved Hide resolved
docs/how-to-guides/sensor-calibration.md Outdated Show resolved Hide resolved
docs/how-to-guides/sensor-calibration.md Outdated Show resolved Hide resolved
docs/how-to-guides/sensor-calibration.md Outdated Show resolved Hide resolved
Lalith Vipulananthan added 3 commits June 20, 2022 15:40
Signed-off-by: Lalith Vipulananthan <lalith.vipulananthan@tier4.jp>
Signed-off-by: Lalith Vipulananthan <lalith.vipulananthan@tier4.jp>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine as an initial document - lidar-lidar and lidar-camera calibration can be filled in later.

@ghost ghost merged commit 3b1a8e5 into autowarefoundation:main Jun 20, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant