Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(troubleshooting): add multicast settings #144

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented Jun 13, 2022

Description

I got an error during launching Autoware.
So I've updated the troubleshooting guide.

Related: autowarefoundation/autoware#204 (comment)

Note: The words Runtime errors are replaced by Runtime issues to be consistent with other sections.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake kenji-miyake requested a review from a user June 13, 2022 00:39
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest making the error message and troubleshooting command more generalized, thus removing the need for the note.

docs/support/troubleshooting.md Outdated Show resolved Hide resolved
docs/support/troubleshooting.md Outdated Show resolved Hide resolved
docs/support/troubleshooting.md Outdated Show resolved Hide resolved
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake kenji-miyake requested a review from a user June 13, 2022 03:03
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenji-miyake kenji-miyake merged commit caab3ba into main Jun 13, 2022
@kenji-miyake kenji-miyake deleted the update-launch-settings branch June 13, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant