Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guidelines): update integration unit testing guidelines #142

Merged
2 commits merged into from Jun 10, 2022
Merged

docs(guidelines): update integration unit testing guidelines #142

2 commits merged into from Jun 10, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 10, 2022

Signed-off-by: Lalith Vipulananthan lalith.vipulananthan@tier4.jp

Description

Minor fixes for the newly added integration and unit testing guidelines

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Lalith Vipulananthan <lalith.vipulananthan@tier4.jp>
@ghost ghost requested a review from maxime-clem June 10, 2022 06:37
@ghost ghost added the type:documentation Creating or refining documentation. label Jun 10, 2022
Minor fix

Signed-off-by: Lalith Vipulananthan <lalith.vipulananthan@tier4.jp>
@ghost ghost requested a review from kenji-miyake June 10, 2022 06:41
Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English and notes are improved.

Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@ghost ghost merged commit d7d36d7 into autowarefoundation:main Jun 10, 2022
@ghost ghost deleted the update-integration-unit-testing-guidelines branch June 10, 2022 07:06
soblin pushed a commit to soblin/autoware-documentation that referenced this pull request Jun 10, 2022
…efoundation#142)

* docs(guidelines): update integration unit testing guidelines

Signed-off-by: Lalith Vipulananthan <lalith.vipulananthan@tier4.jp>

* Update integration-testing.md

Minor fix

Signed-off-by: Lalith Vipulananthan <lalith.vipulananthan@tier4.jp>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Creating or refining documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants