[SDK-3537] Credential manager for React Native #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to ensure we have same API for both iOS and Android. This is a pattern used in our Flutter SDK as well
poovamraj
changed the title
poovamraj
changed the title
|
👋🏻 Should this be going into |
There was a problem hiding this comment.
LGTM, just left a few comments.
Also we should get @Widcket to review the iOS implementation, if she hasn't had a look already.
src/credentials-manager/index.js
Outdated
Comment on lines
5
to
10
| /** | ||
| * Construct an instance of CredentialsManager which can be used to | ||
| * store, retrieve and manage credentials. | ||
| * | ||
| * @param {*} auth - required - instance of Auth0 Auth API | ||
| */ |
There was a problem hiding this comment.
I think this is an improvement but we should document the actual fields like we've done for other methods (saveCredentials, for example).
instance of Auth0 Auth API
Is this correct? Why do we require the whole instance of the Auth API, only to extract domain and clientId and then not use the instance?
stevehobbsdev
previously approved these changes
Aug 17, 2022
Widcket
reviewed
Aug 17, 2022
stevehobbsdev
approved these changes
Aug 18, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We have provided Credentials Manager support for Android and iOS in React Native. The following methods are added
We also return a boolean value from Android API for
clearCredentials. This is to be same to our iOS API and Flutter APIThis PR is a superset of #497 and will have all the changes and reviews from there implemented.
References
#476
Testing
Checklist