[SDK-3534] Credential manager support #497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poovamraj
changed the title
Comment on lines
+18
to
+19
| * @param {Number} credentials.expiresIn optional - `expiresAt` should not be empty if this is. Used to denote when the token will expire from the issued time | ||
| * @param {String} credentials.expiresAt optional - `expiresIn` should not be empty if this is. Used to denote when the token will expire. Has precendence over `expiresIn`. |
There was a problem hiding this comment.
Not sure on the docs here. Looking at the code, either expiresIn or expiresAt is required but at least one of them must be specified, but the docs say they're both optional.
Edit: ok I see now:
credentials.expiresIn optional -
expiresAtshould not be empty if this is.
I found this really confusing and we should reword. How about:
"credentials.expiresIn - optional if expiresAt is set.."
And the converse for expiresAt.
| } | ||
|
|
||
| //private | ||
| async ensureCredentialManagerIsInitialized() { |
There was a problem hiding this comment.
Should we prefix this?
i.e. _ensureCredentialManagerIsInitialized
|
Will we be adding tests here or in a follow-up PR? I'm not seeing any in the diff. |
Co-authored-by: Steve Hobbs <steve.hobbs.mail@gmail.com>
Co-authored-by: Steve Hobbs <steve.hobbs.mail@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We have provided Credentials Manager support for Android in React Native. The following methods are added
References
#476
Testing
Checklist