Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompts partials #979

Closed
wants to merge 7 commits into from
Closed

Prompts partials #979

wants to merge 7 commits into from

Conversation

m3talsmith
Copy link
Contributor

🔧 Changes

Adds support for prompts partials API.

📚 References

🔬 Testing

  • Unit tests included
  • Must use an enterprise account with a custom domain and branding to manually test successfully

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@m3talsmith m3talsmith requested a review from a team as a code owner February 16, 2024 15:31
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

Attention: 229 lines in your changes are missing coverage. Please review.

Comparison is base (54e9a30) 72.32% compared to head (e0a01e7) 71.33%.

Files Patch % Lines
internal/cli/prompts_partials.go 36.63% 207 Missing and 4 partials ⚠️
internal/display/prompts_partials.go 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
- Coverage   72.32%   71.33%   -0.99%     
==========================================
  Files          93       95       +2     
  Lines       12754    13103     +349     
==========================================
+ Hits         9224     9347     +123     
- Misses       2980     3203     +223     
- Partials      550      553       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@developerkunal
Copy link
Contributor

Closing this in respect to #1031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants