Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CLI Custom Prompts [HACKATHON] #1031

Merged
merged 17 commits into from
Aug 12, 2024
Merged

feat: CLI Custom Prompts [HACKATHON] #1031

merged 17 commits into from
Aug 12, 2024

Conversation

developerkunal
Copy link
Contributor

@developerkunal developerkunal commented Jun 18, 2024

🔧 Changes

  • Added Support for Partial prompts on Universal Login Customize command.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@developerkunal developerkunal requested a review from a team as a code owner June 18, 2024 06:38
@developerkunal developerkunal mentioned this pull request Jul 4, 2024
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 39.56044% with 55 lines in your changes missing coverage. Please review.

Project coverage is 72.16%. Comparing base (f5c05e5) to head (ee48a05).

Files Patch % Lines
internal/cli/universal_login_customize.go 39.56% 55 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1031      +/-   ##
==========================================
- Coverage   72.34%   72.16%   -0.19%     
==========================================
  Files          94       94              
  Lines       12781    12871      +90     
==========================================
+ Hits         9247     9288      +41     
- Misses       2984     3035      +51     
+ Partials      550      548       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@developerkunal developerkunal requested a review from a team as a code owner August 2, 2024 12:39
@developerkunal developerkunal merged commit 907c203 into main Aug 12, 2024
8 checks passed
@developerkunal developerkunal deleted the feat/hack-4857 branch August 12, 2024 07:42
@developerkunal developerkunal restored the feat/hack-4857 branch September 2, 2024 12:14
@developerkunal developerkunal deleted the feat/hack-4857 branch September 2, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants