Updated Quick and Nimble #97
Conversation
|
@lbalmaceda can you please update the branch protection settings? The only CircleCI jobs that should be marked as required are build-and-test-iOS, build-and-test-macOS, build-and-test-tvOS as the others have been removed. |
README.md
Outdated
| @@ -16,6 +16,9 @@ A wrapper to make it really easy to deal with iOS Keychain and store your user's | |||
| - Store credentials under an **Access Group to enable Keychain Sharing**. | |||
| - **TouchID/FaceID integration** with a reusable `LAContext` instance. | |||
|
|
|||
| ## Important Notices | |||
There was a problem hiding this comment.
The requirements section does not match this requirement. We also can't say for sure it works on lower versions as no testing in place to validate this.
There was a problem hiding this comment.
I removed the notice and updated the requirements. One is not compatible with the other because the notice says "developers using Carthage", while the requirements are for everyone. From the PoV of an external observer, we would be warning Carthage developers about something that is moot because the requirements themselves say the library needs Xcode 11.4+.
There was a problem hiding this comment.
That is, the updated requirements supersede the notice. If we'd prefer to use the notice, then we should keep the old requirements.
Done |
Changes
This PR updates the test dependencies Quick and Nimble to the latest majors, making it possible to test SimpleKeychain with Xcode 12.
The new majors of Quick and Nimble no longer support Swift versions < 5.2. This means that the tests can no longer be run on Xcode versions < 11.4. The CircleCI config has been updated accordingly.
The requirements section in the README has been updated as well.
References
Same changes in Auth0.swift: auth0/Auth0.swift#421
Same changes in JWTDecode.swift: auth0/JWTDecode.swift#114
Testing
Checklist