Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated CI config to match the other iOS repos #639

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Updated CI config to match the other iOS repos #639

merged 2 commits into from
Oct 13, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Oct 12, 2020 •
edited
Loading

Changes

This PR updates the CI config to match the ones used in SimpleKeychain and JWTDecode.swift, with the latest changes:

  • Update the iPhone simulator to iPhone 11
  • Update gems
  • Fix Ruby Gems caching
  • Fix the saving of artifacts and test results
  • Remove redundant settings
  • Disable automatic run of brew cleanup

References

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added the review:small Small review label Oct 12, 2020
@Widcket Widcket requested a review from a team October 12, 2020 21:59
@Widcket Widcket merged commit 2d36d97 into master Oct 13, 2020
@Widcket Widcket deleted the chore/update-ci-config branch October 13, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocojoe cocojoe cocojoe approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @cocojoe