Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draw background and borders on programmatically created fields #455

Merged
merged 2 commits into from
Feb 26, 2018
Merged

Draw background and borders on programmatically created fields #455

merged 2 commits into from
Feb 26, 2018

Conversation

lbalmaceda
Copy link
Contributor

Background and Border styles application was skipped when the view was instantiated programmatically.
Fixes #454

Empty field

image

Error validation

image

@lbalmaceda lbalmaceda requested a review from cocojoe February 26, 2018 14:57
cocojoe
cocojoe approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbalmaceda lbalmaceda added this to the v2-Next milestone Feb 26, 2018
@lbalmaceda lbalmaceda merged commit b60bb6b into master Feb 26, 2018
@lbalmaceda lbalmaceda modified the milestones: v2-Next, 2.8.2 Feb 26, 2018
@lbalmaceda lbalmaceda deleted the fix-custom-fields-style branch May 4, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisrudge luisrudge luisrudge approved these changes

@cocojoe cocojoe cocojoe approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
2.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@lbalmaceda @cocojoe @luisrudge