Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fields have no border styling. #454

Closed
mcbridet opened this issue Feb 23, 2018 · 5 comments
Closed

Custom fields have no border styling. #454

mcbridet opened this issue Feb 23, 2018 · 5 comments

Comments

@mcbridet
Copy link

mcbridet commented Feb 23, 2018

When a custom field is added, the border styling applied to the email / username / password fields (ones that are not custom) is not applied.

Code snippet or sample project that reproduces the bug:

Lock implementation:

CustomField fieldName = new CustomField(R.drawable.com_auth0_lock_ic_username, CustomField.FieldType.TYPE_NAME, "name", R.string.hint_name);
List<CustomField> fields = new ArrayList<>();
fields.add(fieldName);
mLock = Lock.newBuilder(mAuth0, new AuthenticationCallback() {...})
        .withSignUpFields(fields)
        .allowSignUp(true)
...
        .build(this);

Lock theme:

<style name="LockTheme" parent="Lock.Theme">
        <item name="Auth0.HeaderLogo">@drawable/ui_logo_app</item>
        <item name="Auth0.HeaderTitle">@string/log_in_text</item>
        <item name="Auth0.HeaderTitleColor">@color/md_grey_900</item>
        <item name="Auth0.HeaderBackground">@color/appPrimaryBand</item>
        <item name="Auth0.PrimaryColor">@color/appPrimaryDark</item>
        <item name="Auth0.DarkPrimaryColor">@color/appPrimaryDarker</item>
        <item name="android:windowLightStatusBar" tools:targetApi="m">true</item>
    </style>

Screenshots when appropriate:

image

Lock version: 2.8.1.
Android version & Phone Model when appropriate: Samsung Galaxy S7 (SM-G930F), Android 7.0.
Versions of Gradle, Android Plugin, Build tools & Android SDK:

Gradle: 4.4.
Android Plugin: 3.0.1.
SDK & Build Tools: 26 / 26.0.3.

@lbalmaceda
Copy link
Contributor

Thanks for such detailed report.

Lock version: 2.3.0.

Is this issue happening on the latest version as well?

@mcbridet
Copy link
Author

Sorry, no idea what compelled me to put that in. I am using 2.8.1 (updated issue), and re-tested again just to be sure. :)

It is an issue on release 2.8.1.

@lbalmaceda
Copy link
Contributor

Perfect. I'll look into it this week. 👋

@lbalmaceda
Copy link
Contributor

@deviousgeek This is fixed on 2.8.2.

@mcbridet
Copy link
Author

Legend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants