-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added watchOS support #91
Conversation
Apologies I've not had time to try this, it looks okay at a glance, although not being able to run test is not ideal. I would like to take a look at that, to set expectation I'm on vacation so will be a bit delayed in response. Thanks |
No worries, fwiw we've been running on WatchOS for the last couple weeks here and haven't run into any problems 🙂 |
@jklp please update README with watchOS support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks fine, just update README and PodSpec, check dependency version against project.
@cocojoe Hi, I updated the podspec and tested (and it works) though I might need some help with the other 2 items. I'm not 100% on what to update in the README (I can't find anything which would be platform specific to watchOS) and I'm not sure what you mean by the dependency version (sorry!) |
@jklp fair question as there was no existing WatchOS support, what's the minimum version that can be specified in the project? Would be ideal to match our other libraries e.g. https://github.com/auth0/Auth0.swift#requirements When I said dependency I mean the deployment version in the PodSpec should match the project. I would use the newer swift versions syntax as well which is demonstrated here for language version support in this PR. auth0/Auth0.swift#279 |
# Conflicts: # JWTDecode.podspec
@cocojoe Hey sorry for the long delay. I've just updated the README.md and also dropped the watchOS version to 2.0 to match the rest the project. Please let me know if there's anything else. Thanks! |
Is this pull request ready to be merged? With Auth0 SIWA available on apple watch as of iOS 13, it would be helpful to be able to read the JWT token on the Watch Extension itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it out, looks okay 👍
Added a target for watchOS. Couldn't add the test target as couldn't get Nimble/Quick to build on watchOS.